-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-panel): panel sticky header implementation #7313
Conversation
repeats in the base and add for horizon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing - I see that there is some flickering on the closing animation when a panel is sticky, which is not present when a panel does not have a sticky header, could you check it out?
fixed with max-height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make the scroll of the container of the story sample bigger since on large screen you cannot see the effect of the two sticky headers
- When a panel is sticky the roundness of the top left and top right border of the panel is missing
- setting sticky: false in the storybook sample does not remove the sticky behavior
All done/fixed |
BGSOFUIRILA-3640