Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-panel): panel sticky header implementation #7313

Merged
merged 12 commits into from
Jul 25, 2023
Merged

feat(ui5-panel): panel sticky header implementation #7313

merged 12 commits into from
Jul 25, 2023

Conversation

Okiana
Copy link
Contributor

@Okiana Okiana commented Jul 11, 2023

BGSOFUIRILA-3640

niyap
niyap requested changes Jul 11, 2023
View reviewed changes
packages/main/src/themes/Panel.css Outdated Show resolved Hide resolved
packages/main/src/themes/Panel.css Show resolved Hide resolved
packages/main/test/specs/Panel.spec.js Show resolved Hide resolved
packages/main/test/specs/Panel.spec.js Outdated Show resolved Hide resolved
packages/main/test/specs/Panel.spec.js Outdated Show resolved Hide resolved
packages/main/src/themes/sap_belize/Panel-parameters.css Outdated Show resolved Hide resolved
packages/main/src/themes/sap_horizon/Panel-parameters.css Outdated Show resolved Hide resolved
@elenastoyanovaa elenastoyanovaa self-requested a review July 19, 2023 12:13
elenastoyanovaa
elenastoyanovaa requested changes Jul 20, 2023
View reviewed changes
packages/main/src/Panel.hbs Show resolved Hide resolved
packages/main/src/Panel.ts Show resolved Hide resolved
packages/main/src/themes/base/Panel-parameters.css Outdated Show resolved Hide resolved
@Okiana
feat(ui5-panel): update parameters - use the one which
4c541a8 
repeats in the base and add for horizon
elenastoyanovaa
elenastoyanovaa requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing - I see that there is some flickering on the closing animation when a panel is sticky, which is not present when a panel does not have a sticky header, could you check it out?

@Okiana
Copy link
Contributor Author

Okiana commented Jul 25, 2023

Last thing - I see that there is some flickering on the closing animation when a panel is sticky, which is not present when a panel does not have a sticky header, could you check it out?

fixed with max-height

@Okiana Okiana closed this Jul 25, 2023
@Okiana Okiana reopened this Jul 25, 2023
elenastoyanovaa
elenastoyanovaa requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make the scroll of the container of the story sample bigger since on large screen you cannot see the effect of the two sticky headers
  • When a panel is sticky the roundness of the top left and top right border of the panel is missing
  • setting sticky: false in the storybook sample does not remove the sticky behavior

packages/playground/_stories/main/Panel/Panel.stories.ts Show resolved Hide resolved
@Okiana
Copy link
Contributor Author

Okiana commented Jul 25, 2023

  • Make the scroll of the container of the story sample bigger since on large screen you cannot see the effect of the two sticky headers
  • When a panel is sticky the roundness of the top left and top right border of the panel is missing
  • setting sticky: false in the storybook sample does not remove the sticky behavior

All done/fixed

@Okiana Okiana requested a review from niyap July 25, 2023 14:00
@Okiana Okiana merged commit 18c0e4f into main Jul 25, 2023
5 checks passed
@nnaydenow nnaydenow deleted the panelStickyHeader branch October 20, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenastoyanovaa elenastoyanovaa elenastoyanovaa approved these changes

@simonarangelova simonarangelova simonarangelova approved these changes

@niyap niyap niyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Okiana @elenastoyanovaa @simonarangelova @niyap