-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-tabcontainer): implement latest SAP Horizon design #7257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
Just something small I noticed - the semantic colors are not correct in all cases:
- in Horizon/Horizon Dark they look like are slightly different
- in Horizon HCB/ HCW the text only tabs should be the same color (all black/ all white), only the small icons should be semantic
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Two click area
- Separator right padding is -1px, while the spec says it should be 0px?
- Button is not vertically centered
- Overflow button
- not vertically centered
- hover and regular states are changed - regular should be white, hover should be gray
Two click area - the -1px padding is to make it hide on button hover. Centering is fixed |
No description provided.