Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-tabcontainer): implement latest SAP Horizon design #7257

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

dimovpetar
Copy link
Contributor

No description provided.

@dimovpetar dimovpetar requested a review from a team June 27, 2023 14:17
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
Just something small I noticed - the semantic colors are not correct in all cases:

  • in Horizon/Horizon Dark they look like are slightly different
  • in Horizon HCB/ HCW the text only tabs should be the same color (all black/ all white), only the small icons should be semantic

@dimovpetar
Copy link
Contributor Author

dimovpetar commented Jul 5, 2023

Overall looks good. Just something small I noticed - the semantic colors are not correct in all cases:

  • in Horizon/Horizon Dark they look like are slightly different
  • in Horizon HCB/ HCW the text only tabs should be the same color (all black/ all white), only the small icons should be semantic
  1. the parameters are correct, I guess their values are to be updated
  2. fixed

Copy link
Contributor

@alexandar-mitsev alexandar-mitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Two click area
    • Separator right padding is -1px, while the spec says it should be 0px?
    • Button is not vertically centered
  • Overflow button
    • not vertically centered
    • hover and regular states are changed - regular should be white, hover should be gray

@dimovpetar
Copy link
Contributor Author

dimovpetar commented Jul 7, 2023

  • Two click area

    • Separator right padding is -1px, while the spec says it should be 0px?
    • Button is not vertically centered
  • Overflow button

    • not vertically centered
    • hover and regular states are changed - regular should be white, hover should be gray

Two click area - the -1px padding is to make it hide on button hover. Centering is fixed
Overflow button - CSS parameters are not updated yet. It will look as designed once they are updated. Centering is fixed

@dimovpetar dimovpetar merged commit 9ee9ec4 into main Jul 7, 2023
5 checks passed
@dimovpetar dimovpetar deleted the tabcontainer_horizon branch July 7, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants