fix(ui5-upload-collection): prevent item-delete event from firing when item name is deleted
#11625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stoev
reviewed
May 30, 2025
There was a problem hiding this comment.
Please consider:
fix(ui5-upload-collection): prevent item delete event from firing when item name is deleted #11625
Also, if you consider of added value might add some explanatory text:
When editing a file name in the UploadCollectionItem, pressing the Del key no longer fires the 'item-delete' event.
dimovpetar
changed the title
item-delete event from firing when item name is deleted
Done |
TeodorTaushanov
requested changes
Jun 4, 2025
TeodorTaushanov
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a file name in the UploadCollectionItem, pressing the Del key no longer fires the 'item-delete' event.
Fixes #11592