feat(ui5-combobox/multi-combobox): physical items #10051
+469
−497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dobrinyonkov I have some changes in the list if something is not clear please contact me. Basically, Since the combobox and the multicombobox are filtering their items internally, I need to render inidividual slots just for filtered items. That breaks the Item Navigation in the list and I had to enhance it |
|
|
||
| onEnterDOM(): void { | ||
| super.onEnterDOM(); | ||
| this.setAttribute("accessible-role", "Option"); |
There was a problem hiding this comment.
This might not work as it is a property of the ListItem and not the ListItemBase. What you can do is override the listItemAttributes inline template of the ListItemBase.hbs, similarly to the ui5-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed items to the
ui5-comboboxandui5-multi-comboboxare now physically slotted to the internal list of the picker.