Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-toolbar-button): ensure getDomRef() returns the actual DOM reference #10009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-toolbar-button): ensure getDomRef() returns the actual DOM reference #10009

wants to merge 1 commit into from
+7 −0

Commits on Oct 11, 2024

  1. fix(ui5-toolbar-button): ensure getDomRef() returns the actual DOM re… 

    …ference

This commit fixes the issue where `getDomRef()` on `ui5-toolbar-button`
was returning `undefined` by providing a custom implementation that
correctly returns the DOM reference to the actual `ui5-button` element
rendered within the `ui5-toolbar`'s shadow DOM. This enhancement ensures
that developers can reliably interact with the toolbar button's DOM
element.

**Notes:**
- This fix assumes that `ui5-toolbar-button` is a direct child of
  `ui5-toolbar`.
- If the component hierarchy changes, additional checks may be necessary
  to ensure the parent toolbar is correctly identified.

Fixes: #9996
    @kgogov
    kgogov committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0ebcefa View commit details
    Browse the repository at this point in the history