Skip to content

Commit

Permalink
feat(ui5-dynamic-page): apply review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kineticjs committed Nov 20, 2023
1 parent a8b2749 commit d58eb59
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/fiori/src/DynamicPageTitle.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</div>

<div class="{{classes.wrapper}}"
@ui5-_minContentWidthChange={{onMinContentWidthChange}}>
@ui5-_min-content-width-change={{onMinContentWidthChange}}>
<div class="{{classes.heading}}">
<slot name="{{headingSlotName}}"></slot>
</div>
Expand Down
5 changes: 3 additions & 2 deletions packages/main/src/Toolbar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,9 @@ class Toolbar extends UI5Element {
}

if (minWidth !== this.minContentWidth) {
this.fireEvent<ToolbarMinWidthChangeEventDetail>("_minContentWidthChange", {
minWidth,
const spaceAroundContent = this.offsetWidth - this.getDomRef()!.offsetWidth;
this.fireEvent<ToolbarMinWidthChangeEventDetail>("_min-content-width-change", {
minWidth: minWidth + spaceAroundContent,
});
}

Expand Down

0 comments on commit d58eb59

Please sign in to comment.