chore(framework): features loading (#9586)

With this change race condition where feature is loaded while component is defining its dependencies and its handler for feature loading is not attached is handled.
SAP · Jul 31, 2024 · cf4eb7d · cf4eb7d
1 parent 20cc921
commit cf4eb7d
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 11 deletions.
diff --git a/packages/ai/package.json b/packages/ai/package.json
@@ -52,6 +52,6 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "2.1.0-rc.2",
-    "chromedriver": "^125.0.0"
+    "chromedriver": "^126.0.0"
   }
 }
diff --git a/packages/base/package.json b/packages/base/package.json
@@ -52,7 +52,7 @@
   "devDependencies": {
     "@openui5/sap.ui.core": "1.120.17",
     "@ui5/webcomponents-tools": "2.1.0-rc.2",
-    "chromedriver": "^125.0.0",
+    "chromedriver": "^126.0.0",
     "clean-css": "^5.2.2",
     "copy-and-watch": "^0.1.5",
     "cross-env": "^7.0.3",

diff --git a/packages/base/src/UI5Element.ts b/packages/base/src/UI5Element.ts
@@ -37,7 +37,7 @@ import type {
 } from "./types.js";
 import { attachFormElementInternals, setFormValue } from "./features/InputElementsFormSupport.js";
 import type { IFormInputElement } from "./features/InputElementsFormSupport.js";
-import { subscribeForFeatureLoad } from "./FeaturesRegistry.js";
+import { getComponentFeature, subscribeForFeatureLoad } from "./FeaturesRegistry.js";
 
 const DEV_MODE = true;
 let autoId = 0;
@@ -1220,6 +1220,10 @@ abstract class UI5Element extends HTMLElement {
 		const features = this.getMetadata().getFeatures();
 
 		features.forEach(feature => {
+			if (getComponentFeature(feature)) {
+				this.cacheUniqueDependencies();
+			}
+
 			subscribeForFeatureLoad(feature, this, this.cacheUniqueDependencies.bind(this));
 		});
 

diff --git a/packages/compat/package.json b/packages/compat/package.json
@@ -52,6 +52,6 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "2.1.0-rc.2",
-    "chromedriver": "^125.0.0"
+    "chromedriver": "^126.0.0"
   }
 }
diff --git a/packages/fiori/package.json b/packages/fiori/package.json
@@ -54,6 +54,6 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "2.1.0-rc.2",
-    "chromedriver": "^125.0.0"
+    "chromedriver": "^126.0.0"
   }
 }
diff --git a/packages/localization/package.json b/packages/localization/package.json
@@ -35,7 +35,7 @@
     "@openui5/sap.ui.core": "1.120.17",
     "@ui5/webcomponents-tools": "2.1.0-rc.2",
     "babel-plugin-amd-to-esm": "^2.0.3",
-    "chromedriver": "^125.0.0",
+    "chromedriver": "^126.0.0",
     "estree-walk": "^2.2.0",
     "mkdirp": "^1.0.4",
     "resolve": "^1.20.0"

diff --git a/packages/main/package.json b/packages/main/package.json
@@ -59,6 +59,6 @@
   },
   "devDependencies": {
     "@ui5/webcomponents-tools": "2.1.0-rc.2",
-    "chromedriver": "^125.0.0"
+    "chromedriver": "^126.0.0"
   }
 }
diff --git a/yarn.lock b/yarn.lock
@@ -6094,10 +6094,10 @@ chrome-trace-event@^1.0.2:
   resolved "https://registry.yarnpkg.com/chrome-trace-event/-/chrome-trace-event-1.0.3.tgz#1015eced4741e15d06664a957dbbf50d041e26ac"
   integrity sha512-p3KULyQg4S7NIHixdwbGX+nFHkoBiA4YQmyWtjb8XngSKV124nJmRysgAeujbUVb15vh+RvFUfCPqU7rXk+hZg==
 
-chromedriver@^125.0.0:
-  version "125.0.0"
-  resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-125.0.0.tgz#1fed0351865bf45a3417cbdac45e2dc4257cb876"
-  integrity sha512-wWXrxWLWqXRTmRZDtPigs+ys44srlpHTpsL7MHnZc9iaE1oIB0hslSVeem6TcsEb1Ou8nvPx3vs5bPwCI6+VHg==
+chromedriver@^126.0.0:
+  version "126.0.5"
+  resolved "https://registry.yarnpkg.com/chromedriver/-/chromedriver-126.0.5.tgz#5db6f463c7557e3a76b7fe7fb73aaf2f06fd07e6"
+  integrity sha512-xXVxwxd8CJ6yg2KEvFqLQi7V0RvF78xFnLB+xo9g9MoJNHMQccD7b4OWaxtKDy5RXrMgQ6Jb6vUN3SjTYXHLEQ==
   dependencies:
     "@testim/chrome-version" "^1.1.4"
     axios "^1.6.7"