chore: describe correct dependencies (#9174)

When a component is using another components in its template, used components must be added to its dependencies in order to get the same scoping.
SAP · Jun 11, 2024 · cd4f9b0 · cd4f9b0
1 parent 7f33c81
commit cd4f9b0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/packages/main/src/Grid.ts b/packages/main/src/Grid.ts
@@ -149,7 +149,11 @@ type GridRowClickEventDetail = {
 	styles: GridStyles,
 	template: GridTemplate,
 	fastNavigation: true,
-	dependencies: [BusyIndicator, GridCell],
+	dependencies: [
+		BusyIndicator,
+		GridCell,
+		GridRow,
+	],
 })
 
 /**
@@ -250,7 +254,7 @@ class Grid extends UI5Element {
 	 * @default false
 	 * @public
 	 */
-	@property({ type: Boolean, defaultValue: false })
+	@property({ type: Boolean })
 	loading!: boolean;
 
 	/**
@@ -300,6 +304,7 @@ class Grid extends UI5Element {
 	}
 
 	onBeforeRendering(): void {
+		this.style.setProperty(getScopedVarName("--ui5_grid_sticky_top"), this.stickyTop);
 		this._refreshPopinState();
 	}
 

diff --git a/packages/main/src/GridHeaderRow.ts b/packages/main/src/GridHeaderRow.ts
@@ -71,13 +71,6 @@ class GridHeaderRow extends GridRowBase {
 	@property({ type: Boolean })
 	sticky!: boolean;
 
-	onBeforeRendering() {
-		super.onBeforeRendering();
-		if (this._grid) {
-			this.style.top = this._grid.stickyTop;
-		}
-	}
-
 	isHeaderRow() {
 		return true;
 	}

diff --git a/packages/main/src/themes/GridHeaderRow.css b/packages/main/src/themes/GridHeaderRow.css
@@ -10,7 +10,7 @@
 
 :host([sticky]) {
     position: sticky;
-    top: 0;
+    top: var(--ui5_grid_sticky_top, 0);
     z-index: 1;
 }