Skip to content

Commit

Permalink
fix(ui5-illustrated-message): improved story and documentation (#8294)
Browse files Browse the repository at this point in the history
In the "Custom Title" story we had "titleLevel" story control which
didn't take any effect upon being changed. This control has been removed
and "titleLevel" property is now documented that it doesn't work when
we are using "title" slot.
  • Loading branch information
plamenivanov91 authored Feb 16, 2024
1 parent 35ead5b commit 9740fe2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/fiori/src/IllustratedMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ class IllustratedMessage extends UI5Element {
*
* <b>Note:</b> Used for accessibility purposes only.
*
* <br/>
*
* <b>Note:</b> Doesn't take effect when <code>title</code> slot is being used.
*
* @default "H2"
* @public
* @since 1.20.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,7 @@ CustomTitle.args = {
default: `
<ui5-button icon="refresh">Try again</ui5-button>`,
};

CustomTitle.parameters = {
controls: { exclude: ['titleLevel'] },
};

0 comments on commit 9740fe2

Please sign in to comment.