Skip to content

Commit

Permalink
docs: rewrite JSDoc for custom-elements-manifest/analyzer
Browse files Browse the repository at this point in the history
Related to: #7610
  • Loading branch information
s-todorova committed Nov 27, 2023
1 parent d456375 commit 67e6abc
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 20 deletions.
16 changes: 8 additions & 8 deletions packages/fiori/src/SideNavigationItemBase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ import { isSpace, isEnter } from "@ui5/webcomponents-base/dist/Keys.js";
import type { ITabbable } from "@ui5/webcomponents-base/dist/delegate/ItemNavigation.js";
import type SideNavigation from "./SideNavigation.js";

/**
* Fired when the component is activated either with a
* click/tap or by using the Enter or Space key.
*
* @public
*/
@event("click")

/**
* @class
* A class to serve as a foundation
Expand All @@ -16,14 +24,6 @@ import type SideNavigation from "./SideNavigation.js";
* @public
* @since 1.19.0
*/

/**
* Fired when the component is activated either with a
* click/tap or by using the Enter or Space key.
*
* @public
*/
@event("click")
class SideNavigationItemBase extends UI5Element implements ITabbable {
/**
* Defines the text of the item.
Expand Down
6 changes: 0 additions & 6 deletions packages/main/src/BusyIndicator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,6 @@ class BusyIndicator extends UI5Element {
@property({ type: Boolean })
_isBusy!: boolean;

/**
* Determines the content over which the component will appear.
*
* @public
*/

_keydownHandler: (e: KeyboardEvent) => void;
_preventEventHandler: (e: KeyboardEvent) => void;
_busyTimeoutId?: Timeout;
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/Carousel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ class Carousel extends UI5Element {
* @since 1.0.0-rc.15
* @public
*/
navigateTo(itemIndex: number) {
navigateTo(itemIndex: number) : void {
this._resizing = false;
this._selectedIndex = itemIndex;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/Popup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ abstract class Popup extends UI5Element {
* Tells if the component is opened
* @public
*/
isOpen() {
isOpen() : boolean {
return this.opened;
}

Expand Down Expand Up @@ -485,7 +485,7 @@ abstract class Popup extends UI5Element {
* Closes the popup.
* @public
*/
close(escPressed = false, preventRegistryUpdate = false, preventFocusRestore = false) {
close(escPressed = false, preventRegistryUpdate = false, preventFocusRestore = false) : void {
if (!this.opened) {
return;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/ResponsivePopover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class ResponsivePopover extends Popover {
* Closes the popover/dialog.
* @public
*/
close(escPressed = false, preventRegistryUpdate = false, preventFocusRestore = false) {
close(escPressed = false, preventRegistryUpdate = false, preventFocusRestore = false) : void {
if (!isPhone()) {
super.close(escPressed, preventRegistryUpdate, preventFocusRestore);
} else {
Expand All @@ -128,7 +128,7 @@ class ResponsivePopover extends Popover {
* Tells if the responsive popover is open.
* @public
*/
isOpen() {
isOpen() : boolean {
return (isPhone() && this._dialog) ? this._dialog.isOpen() : super.isOpen();
}

Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/Tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class Tab extends UI5Element implements ITab, ITabbable {
* @public
* @since 1.0.0-rc.16
*/
getTabInStripDomRef() {
getTabInStripDomRef() : ITab | null {
if (this._getElementInStrip) {
return this._getElementInStrip();
}
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/TabContainer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ class TabContainer extends UI5Element {
* Calling <code>allItems</code> on this TabContainer will return the instances in the following order:
* <code>[ ui5-tab#First, ui5-tab#Nested, ui5-tab#Second, ui5-tab-separator#sep, ui5-tab#Third ]</code>
* @public
* @default Array[]
*/
get allItems() : Array<ITab> {
return this._getAllSubItems(this.items);
Expand Down

0 comments on commit 67e6abc

Please sign in to comment.