Skip to content

Commit

Permalink
fix: correct failing test
Browse files Browse the repository at this point in the history
  • Loading branch information
MapTo0 committed Jan 22, 2024
1 parent 4ab74fb commit 57b06fa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/main/src/MultiComboBox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ class MultiComboBox extends UI5Element {
* Determines if the select all checkbox is visible on top of suggestions.
*
* @type {boolean}
* @defaultvalue false
* @default false
* @public
*/
@property({ type: Boolean })
Expand Down
2 changes: 1 addition & 1 deletion packages/main/test/pages/MultiComboBox.html
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@

<br>

<ui5-multi-combobox show-select-all id="mcb-select-all-vs">
<ui5-multi-combobox show-select-all id="mcb-select-all">
<ui5-mcb-item text="Qui minim"></ui5-mcb-item>
<ui5-mcb-item text="minim amet"></ui5-mcb-item>
<ui5-mcb-item text="amet mollit"></ui5-mcb-item>
Expand Down
4 changes: 2 additions & 2 deletions packages/main/test/specs/MultiComboBox.mobile.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ describe("Items selection", () => {
});

it ("should select all items when clicking select all", async () => {
const cb = await $("#mcb-select-all");
const staticAreaItemClassName = await browser.getStaticAreaItemClassName("#mcb-select-all");
const cb = await $("#mcb-select-all-vs");
const staticAreaItemClassName = await browser.getStaticAreaItemClassName("#mcb-select-all-vs");
const popover = await $(`.${staticAreaItemClassName}`).shadow$("ui5-responsive-popover");
const spanRef = await $("#select-all-event");

Expand Down

0 comments on commit 57b06fa

Please sign in to comment.