-
Notifications
You must be signed in to change notification settings - Fork 264
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ui5-shellbar): button focus outline adjustment (#7389)
* fix(ui5-shellbar): button focus outline adjustment This commit addresses an issue identified after the recent update related to runtime-based CSS variables for components. It adjusts the focus outline of the ShellBar buttons across all themes. Fixes #7220 * fix(ui5-shellbar): simplified the outline style
- Loading branch information
Showing
15 changed files
with
134 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,25 @@ | ||
| :root { | ||
| --_ui5_shellbar_root_height: 2.75rem; | ||
| --_ui5_shellbar_logo_outline_color: var(--sapContent_ContrastFocusColor); | ||
| --_ui5_shellbar_logo_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_shellbar_logo_outline_color); | ||
| --_ui5_shellbar_outline_offset: -0.0625rem; | ||
| --_ui5_shellbar_logo_outline_offset: var(--_ui5_shellbar_outline_offset); | ||
| --_ui5_shellbar_button_box_shadow: none; | ||
| --_ui5_shellbar_button_border: none; | ||
| --_ui5_shellbar_button_border_radius: 0.25rem; | ||
| --_ui5_shellbar_button_active_color: var(--sapShell_Active_TextColor); | ||
| --_ui5_shellbar_logo_outline_border_radius: 0; | ||
| --_ui5_shellbar_copilot_stop_color1: #C0D9F2; | ||
| --_ui5_shellbar_copilot_stop_color2: #FFFFFF; | ||
| --_ui5_shellbar_copilot_focus_offset: 0; | ||
| --_ui5_shellbar_search_button_size: 2.25rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_button_border_radius: 0.25rem; | ||
| --_ui5_shellbar_search_field_background: var(--sapShellColor); | ||
| --_ui5_shellbar_search_field_border: 1px solid var(--sapShell_InteractiveBorderColor); | ||
| --_ui5_shellbar_search_field_color: var(--sapShell_TextColor); | ||
| --_ui5_shellbar_search_field_outline_focused: 1px dotted var(--sapContent_ContrastFocusColor); | ||
| --_ui5_shellbar_overflow_container_middle_height: 2.5rem; | ||
| --_ui5_shellbar_menu_button_title_font_size: 0.75rem; | ||
| :root { | ||
| --_ui5_shellbar_root_height: 2.75rem; | ||
| --_ui5_shellbar_logo_outline_color: var(--sapContent_ContrastFocusColor); | ||
| --_ui5_shellbar_logo_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_shellbar_logo_outline_color); | ||
| --_ui5_shellbar_outline_offset: -0.0625rem; | ||
| --_ui5_shellbar_logo_outline_offset: var(--_ui5_shellbar_outline_offset); | ||
| --_ui5_shellbar_button_box_shadow: none; | ||
| --_ui5_shellbar_button_border: none; | ||
| --_ui5_shellbar_button_border_radius: 0.25rem; | ||
| --_ui5_shellbar_button_focused_border: 0.0625rem dotted var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_button_active_color: var(--sapShell_Active_TextColor); | ||
| --_ui5_shellbar_logo_outline_border_radius: 0; | ||
| --_ui5_shellbar_copilot_stop_color1: #C0D9F2; | ||
| --_ui5_shellbar_copilot_stop_color2: #FFFFFF; | ||
| --_ui5_shellbar_copilot_focus_offset: 0; | ||
| --_ui5_shellbar_search_button_size: 2.25rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_button_border_radius: 0.25rem; | ||
| --_ui5_shellbar_search_field_background: var(--sapShellColor); | ||
| --_ui5_shellbar_search_field_border: 1px solid var(--sapShell_InteractiveBorderColor); | ||
| --_ui5_shellbar_search_field_color: var(--sapShell_TextColor); | ||
| --_ui5_shellbar_search_field_outline_focused: 1px dotted var(--sapContent_ContrastFocusColor); | ||
| --_ui5_shellbar_overflow_container_middle_height: 2.5rem; | ||
| --_ui5_shellbar_menu_button_title_font_size: 0.75rem; | ||
| } |
5 changes: 5 additions & 0 deletions
5
packages/fiori/src/themes/sap_belize_hcb/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/fiori/src/themes/sap_belize_hcw/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/fiori/src/themes/sap_fiori_3_hcb/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/fiori/src/themes/sap_fiori_3_hcw/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 34 additions & 33 deletions
67
packages/fiori/src/themes/sap_horizon/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,35 @@ | ||
| :root { | ||
| --_ui5_shellbar_root_height: 3.25rem; | ||
| --_ui5_shellbar_logo_outline_color: var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_logo_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_shellbar_logo_outline_color); | ||
| --_ui5_shellbar_logo_outline_offset: -0.125rem; | ||
| --_ui5_shellbar_outline_offset: -0.1875rem; | ||
|
|
||
| --_ui5_shellbar_button_border: none; | ||
| --_ui5_shellbar_button_border_radius: var(--sapButton_BorderCornerRadius); | ||
| --_ui5_shellbar_button_badge_border: 1px solid var(--sapContent_BadgeBackground); | ||
| --_ui5_shellbar_logo_border_radius: 0.5rem; | ||
| --_ui5_shellbar_button_box_shadow: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_button_active_color: var(--sapShell_Active_TextColor); | ||
| --_ui5_shellbar_logo_outline_border_radius: var(--sapField_BorderCornerRadius); | ||
| --_ui5_shellbar_copilot_stop_color1: #0070F2; | ||
| --_ui5_shellbar_copilot_stop_color2: #EBF8FF; | ||
| --_ui5_shellbar_copilot_focus_offset: 3px; | ||
| --_ui5_shellbar_search_button_border_radius: 50%; | ||
| --_ui5_shellbar_search_button_size: 1.75rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_field_background: var(--sapShell_InteractiveBackground); | ||
| --_ui5_shellbar_search_field_border: none; | ||
| --_ui5_shellbar_search_field_color: var(--sapShell_InteractiveTextColor); | ||
| --_ui5_shellbar_search_field_background_hover: var(--sapShell_Hover_Background); | ||
| --_ui5_shellbar_search_field_box_shadow_hover: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_overflow_container_middle_height: 3rem; | ||
| --_ui5_shellbar_menu_button_title_font_size: var(--sapFontHeader5Size); | ||
| } | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_input_border_radius: 1.125rem; | ||
| --_ui5_shellbar_input_focus_border_radius: 1.125rem; | ||
| --_ui5_shellbar_input_background_color: var(--sapShell_InteractiveBackground); | ||
| :root { | ||
| --_ui5_shellbar_root_height: 3.25rem; | ||
| --_ui5_shellbar_logo_outline_color: var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_logo_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_shellbar_logo_outline_color); | ||
| --_ui5_shellbar_logo_outline_offset: -0.125rem; | ||
| --_ui5_shellbar_outline_offset: -0.1875rem; | ||
|
|
||
| --_ui5_shellbar_button_border: none; | ||
| --_ui5_shellbar_button_border_radius: var(--sapButton_BorderCornerRadius); | ||
| --_ui5_shellbar_button_focused_border: 0.125rem solid var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_button_badge_border: 1px solid var(--sapContent_BadgeBackground); | ||
| --_ui5_shellbar_logo_border_radius: 0.5rem; | ||
| --_ui5_shellbar_button_box_shadow: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_button_active_color: var(--sapShell_Active_TextColor); | ||
| --_ui5_shellbar_logo_outline_border_radius: var(--sapField_BorderCornerRadius); | ||
| --_ui5_shellbar_copilot_stop_color1: #0070F2; | ||
| --_ui5_shellbar_copilot_stop_color2: #EBF8FF; | ||
| --_ui5_shellbar_copilot_focus_offset: 3px; | ||
| --_ui5_shellbar_search_button_border_radius: 50%; | ||
| --_ui5_shellbar_search_button_size: 1.75rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_field_background: var(--sapShell_InteractiveBackground); | ||
| --_ui5_shellbar_search_field_border: none; | ||
| --_ui5_shellbar_search_field_color: var(--sapShell_InteractiveTextColor); | ||
| --_ui5_shellbar_search_field_background_hover: var(--sapShell_Hover_Background); | ||
| --_ui5_shellbar_search_field_box_shadow_hover: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_overflow_container_middle_height: 3rem; | ||
| --_ui5_shellbar_menu_button_title_font_size: var(--sapFontHeader5Size); | ||
| } | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_input_border_radius: 1.125rem; | ||
| --_ui5_shellbar_input_focus_border_radius: 1.125rem; | ||
| --_ui5_shellbar_input_background_color: var(--sapShell_InteractiveBackground); | ||
| } |
67 changes: 34 additions & 33 deletions
67
packages/fiori/src/themes/sap_horizon_dark/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,35 @@ | ||
| :root { | ||
| --_ui5_shellbar_root_height: 3.25rem; | ||
| --_ui5_shellbar_logo_outline_color: var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_logo_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_shellbar_logo_outline_color); | ||
| --_ui5_shellbar_logo_outline_offset: -0.125rem; | ||
| --_ui5_shellbar_outline_offset: -0.1875rem; | ||
|
|
||
| --_ui5_shellbar_button_border: none; | ||
| --_ui5_shellbar_button_border_radius: var(--sapButton_BorderCornerRadius); | ||
| --_ui5_shellbar_button_badge_border: 1px solid var(--sapContent_BadgeBackground); | ||
| --_ui5_shellbar_logo_border_radius: 0.5rem; | ||
| --_ui5_shellbar_button_box_shadow: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_button_active_color: var(--sapShell_Active_TextColor); | ||
| --_ui5_shellbar_logo_outline_border_radius: var(--sapField_BorderCornerRadius); | ||
| --_ui5_shellbar_copilot_stop_color1: #0070F2; | ||
| --_ui5_shellbar_copilot_stop_color2: #EBF8FF; | ||
| --_ui5_shellbar_copilot_focus_offset: 3px; | ||
| --_ui5_shellbar_search_button_border_radius: 50%; | ||
| --_ui5_shellbar_search_button_size: 1.75rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_field_background: var(--sapShell_InteractiveBackground); | ||
| --_ui5_shellbar_search_field_border: none; | ||
| --_ui5_shellbar_search_field_color: var(--sapShell_InteractiveTextColor); | ||
| --_ui5_shellbar_search_field_background_hover: var(--sapShell_Hover_Background); | ||
| --_ui5_shellbar_search_field_box_shadow_hover: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_overflow_container_middle_height: 3rem; | ||
| --_ui5_shellbar_menu_button_title_font_size: var(--sapFontHeader5Size); | ||
| } | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_border_radius: 1.125rem; | ||
| --_ui5_shellbar_focus_border_radius: 1.125rem; | ||
| --_ui5_shellbar_background_color: var(--sapShell_InteractiveBackground); | ||
| :root { | ||
| --_ui5_shellbar_root_height: 3.25rem; | ||
| --_ui5_shellbar_logo_outline_color: var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_logo_outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--_ui5_shellbar_logo_outline_color); | ||
| --_ui5_shellbar_logo_outline_offset: -0.125rem; | ||
| --_ui5_shellbar_outline_offset: -0.1875rem; | ||
|
|
||
| --_ui5_shellbar_button_border: none; | ||
| --_ui5_shellbar_button_border_radius: var(--sapButton_BorderCornerRadius); | ||
| --_ui5_shellbar_button_focused_border: 0.125rem solid var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_button_badge_border: 1px solid var(--sapContent_BadgeBackground); | ||
| --_ui5_shellbar_logo_border_radius: 0.5rem; | ||
| --_ui5_shellbar_button_box_shadow: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_button_active_color: var(--sapShell_Active_TextColor); | ||
| --_ui5_shellbar_logo_outline_border_radius: var(--sapField_BorderCornerRadius); | ||
| --_ui5_shellbar_copilot_stop_color1: #0070F2; | ||
| --_ui5_shellbar_copilot_stop_color2: #EBF8FF; | ||
| --_ui5_shellbar_copilot_focus_offset: 3px; | ||
| --_ui5_shellbar_search_button_border_radius: 50%; | ||
| --_ui5_shellbar_search_button_size: 1.75rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_field_background: var(--sapShell_InteractiveBackground); | ||
| --_ui5_shellbar_search_field_border: none; | ||
| --_ui5_shellbar_search_field_color: var(--sapShell_InteractiveTextColor); | ||
| --_ui5_shellbar_search_field_background_hover: var(--sapShell_Hover_Background); | ||
| --_ui5_shellbar_search_field_box_shadow_hover: var(--sapContent_Interaction_Shadow); | ||
| --_ui5_shellbar_overflow_container_middle_height: 3rem; | ||
| --_ui5_shellbar_menu_button_title_font_size: var(--sapFontHeader5Size); | ||
| } | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_border_radius: 1.125rem; | ||
| --_ui5_shellbar_focus_border_radius: 1.125rem; | ||
| --_ui5_shellbar_background_color: var(--sapShell_InteractiveBackground); | ||
| } |
21 changes: 11 additions & 10 deletions
21
packages/fiori/src/themes/sap_horizon_hcb/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_border: var(--sapButton_BorderWidth) solid var(--sapButton_BorderColor); | ||
| --_ui5_shellbar_button_border_radius: var(--sapButton_BorderCornerRadius); | ||
| --_ui5_shellbar_button_badge_border: 1px solid var(--sapGroup_ContentBorderColor); | ||
| --_ui5_shellbar_outline_offset: -0.1875rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_field_outline_focused: none; | ||
| --_ui5_shellbar_menu_button_title_font_size: var(--sapFontHeader5Size); | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_border: var(--sapButton_BorderWidth) solid var(--sapButton_BorderColor); | ||
| --_ui5_shellbar_button_border_radius: var(--sapButton_BorderCornerRadius); | ||
| --_ui5_shellbar_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor); | ||
| --_ui5_shellbar_button_badge_border: 1px solid var(--sapGroup_ContentBorderColor); | ||
| --_ui5_shellbar_outline_offset: -0.1875rem; | ||
| --_ui5_shellbar_search_field_height: 2.25rem; | ||
| --_ui5_shellbar_search_field_outline_focused: none; | ||
| --_ui5_shellbar_menu_button_title_font_size: var(--sapFontHeader5Size); | ||
| } |
5 changes: 5 additions & 0 deletions
5
packages/fiori/src/themes/sap_horizon_hcw/ShellBar-parameters.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @import "../base/ShellBar-parameters.css"; | ||
|
|
||
| :root { | ||
| --_ui5_shellbar_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters