refactor(ui5-popover): fix lint error

SAP · Nov 16, 2023 · 3ab82f4 · 3ab82f4
1 parent 86f1cad
commit 3ab82f4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/main/src/Popover.ts b/packages/main/src/Popover.ts
@@ -464,7 +464,7 @@ class Popover extends Popup {
 		this.arrowTranslateY = placement!.arrow.y;
 
 		top = this._adjustForIOSKeyboard(top);
-		const stackingContextOffset = this._getStackingContextOffset(left, top);
+		const stackingContextOffset = this._getStackingContextOffset();
 		left -= stackingContextOffset.left;
 		top -= stackingContextOffset.top;
 
@@ -495,7 +495,7 @@ class Popover extends Popup {
 		return top + (Number.parseInt(this.style.top || "0") - actualTop);
 	}
 
-	_getStackingContextOffset(left: number, top: number) {
+	_getStackingContextOffset() {
 		let parentNode = this.parentElement ? this.parentNode as HTMLElement : (this.parentNode as ShadowRoot).host as HTMLElement;
 
 		while (parentNode) {

diff --git a/packages/main/test/pages/Popover.html b/packages/main/test/pages/Popover.html
@@ -31,7 +31,7 @@
 		<ui5-tab text="tab 1">
 			<ui5-button id="popbtn">Open Popover</ui5-button>
 
-			<ui5-popover placement-type="Bottom" hide-arrow id="danger">
+			<ui5-dialog placement-type="Bottom" hide-arrow id="danger">
 
 				<ui5-list>
 					<ui5-li>Hello</ui5-li>
@@ -51,7 +51,7 @@
 						<ui5-li>Again</ui5-li>
 					</ui5-list>
 				</ui5-popover>
-			</ui5-popover>
+			</ui5-dialog>
 		</ui5-tab>
 		<ui5-tab text="tab 2">
 
@@ -462,7 +462,7 @@ <h2>Horizontal Align</h2>
 		});
 
 		popbtn.addEventListener("click", function (event) {
-			danger.showAt(popbtn);
+			danger.show(popbtn);
 		});
 
 		bigDanger.addEventListener("click", function (event) {