Skip to content

Commit

Permalink
Merge branch 'main' into feat-select-value
Browse files Browse the repository at this point in the history
  • Loading branch information
ilhan007 committed Nov 16, 2023
2 parents da64938 + e344a02 commit 007138e
Show file tree
Hide file tree
Showing 69 changed files with 284 additions and 230 deletions.
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,25 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)


### Bug Fixes

* **ItemNavigation:** more than 1 ItemNavigation per component allowed ([#7798](https://github.com/SAP/ui5-webcomponents/issues/7798)) ([b1019af](https://github.com/SAP/ui5-webcomponents/commit/b1019aff6c4aced61458c1b718ffe0a3a7802ae2))
* **ui5-segmented-button:** check for items before applying settings ([#7792](https://github.com/SAP/ui5-webcomponents/issues/7792)) ([7f11274](https://github.com/SAP/ui5-webcomponents/commit/7f112746d50381474ec86da5e428df79c17c6499)), closes [#7788](https://github.com/SAP/ui5-webcomponents/issues/7788)
* **ui5-time-picker:** check value before formatting ([#7793](https://github.com/SAP/ui5-webcomponents/issues/7793)) ([70deda8](https://github.com/SAP/ui5-webcomponents/commit/70deda85293d5e62e99530c9dc0747071d9ee59c)), closes [#7790](https://github.com/SAP/ui5-webcomponents/issues/7790)


### Features

* **ui5-illustrated-message:** added new TNT illustrations ([#7773](https://github.com/SAP/ui5-webcomponents/issues/7773)) ([03f28b9](https://github.com/SAP/ui5-webcomponents/commit/03f28b90df0b2a28c0f09f67caaa0a5a1e63c4f3))
* **ui5-side-navigation:** added href and target properties ([#7682](https://github.com/SAP/ui5-webcomponents/issues/7682)) ([7530f00](https://github.com/SAP/ui5-webcomponents/commit/7530f00b589d0b95dcbee49f6ed980e9d36ba58b))





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package ui5-webcomponents
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"packages/playground",
"packages/create-package"
],
"version": "1.19.0",
"version": "1.20.0-rc.0",
"command": {
"publish": {
"allowBranch": "*",
Expand Down
16 changes: 16 additions & 0 deletions packages/base/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,22 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)


### Bug Fixes

* **ItemNavigation:** more than 1 ItemNavigation per component allowed ([#7798](https://github.com/SAP/ui5-webcomponents/issues/7798)) ([b1019af](https://github.com/SAP/ui5-webcomponents/commit/b1019aff6c4aced61458c1b718ffe0a3a7802ae2))


### Features

* **ui5-side-navigation:** added href and target properties ([#7682](https://github.com/SAP/ui5-webcomponents/issues/7682)) ([7530f00](https://github.com/SAP/ui5-webcomponents/commit/7530f00b589d0b95dcbee49f6ed980e9d36ba58b))





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents-base
Expand Down
6 changes: 3 additions & 3 deletions packages/base/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-base",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "UI5 Web Components: webcomponents.base",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand Down Expand Up @@ -37,8 +37,8 @@
"devDependencies": {
"@buxlabs/amd-to-es6": "0.16.1",
"@openui5/sap.ui.core": "1.116.0",
"@ui5/webcomponents-tools": "1.19.0",
"chromedriver": "119.0.0",
"@ui5/webcomponents-tools": "1.20.0-rc.0",
"chromedriver": "117.0.3",
"clean-css": "^5.2.2",
"copy-and-watch": "^0.1.5",
"cross-env": "^7.0.3",
Expand Down
8 changes: 8 additions & 0 deletions packages/create-package/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)

**Note:** Version bump only for package @ui5/create-webcomponents-package





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/create-webcomponents-package
Expand Down
2 changes: 1 addition & 1 deletion packages/create-package/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/create-webcomponents-package",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "UI5 Web Components: create package",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand Down
12 changes: 12 additions & 0 deletions packages/fiori/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)


### Features

* **ui5-illustrated-message:** added new TNT illustrations ([#7773](https://github.com/SAP/ui5-webcomponents/issues/7773)) ([03f28b9](https://github.com/SAP/ui5-webcomponents/commit/03f28b90df0b2a28c0f09f67caaa0a5a1e63c4f3))
* **ui5-side-navigation:** added href and target properties ([#7682](https://github.com/SAP/ui5-webcomponents/issues/7682)) ([7530f00](https://github.com/SAP/ui5-webcomponents/commit/7530f00b589d0b95dcbee49f6ed980e9d36ba58b))





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents-fiori
Expand Down
14 changes: 7 additions & 7 deletions packages/fiori/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-fiori",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "UI5 Web Components: webcomponents.fiori",
"ui5": {
"webComponentsPackage": true
Expand Down Expand Up @@ -41,14 +41,14 @@
"directory": "packages/fiori"
},
"dependencies": {
"@ui5/webcomponents": "1.19.0",
"@ui5/webcomponents-base": "1.19.0",
"@ui5/webcomponents-icons": "1.19.0",
"@ui5/webcomponents-theming": "1.19.0",
"@ui5/webcomponents": "1.20.0-rc.0",
"@ui5/webcomponents-base": "1.20.0-rc.0",
"@ui5/webcomponents-icons": "1.20.0-rc.0",
"@ui5/webcomponents-theming": "1.20.0-rc.0",
"@zxing/library": "^0.17.1"
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.19.0",
"chromedriver": "119.0.0"
"@ui5/webcomponents-tools": "1.20.0-rc.0",
"chromedriver": "117.0.3"
}
}
2 changes: 1 addition & 1 deletion packages/fiori/src/IllustratedMessage.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{{#if hasFormattedTitle}}
<slot name="title"></slot>
{{else}}
<ui5-title level="H2" class="ui5-illustrated-message-title" wrapping-type="Normal">{{effectiveTitleText}}</ui5-title>
<ui5-title level="{{titleLevel}}" class="ui5-illustrated-message-title" wrapping-type="Normal">{{effectiveTitleText}}</ui5-title>
{{/if}}
{{/if}}

Expand Down
15 changes: 15 additions & 0 deletions packages/fiori/src/IllustratedMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/Ari
import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
import Title from "@ui5/webcomponents/dist/Title.js";
import TitleLevel from "@ui5/webcomponents/dist/types/TitleLevel.js";
import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
import IllustrationMessageSize from "./types/IllustrationMessageSize.js";
import IllustrationMessageType from "./types/IllustrationMessageType.js";
Expand Down Expand Up @@ -153,6 +154,20 @@ class IllustratedMessage extends UI5Element {
@property({ defaultValue: "" })
accessibleNameRef!: string;

/**
* Defines the semantic level of the title.
*
* <b>Note:</b> Used for accessibility purposes only.
*
* @type {sap.ui.webc.main.types.TitleLevel}
* @defaultvalue "H2"
* @name sap.ui.webc.fiori.IllustratedMessage.prototype.titleLevel
* @public
* @since 1.20.0
*/
@property({ type: TitleLevel, defaultValue: TitleLevel.H2 })
titleLevel!: `${TitleLevel}`;

/**
* Illustration breakpoint variant for the <code>Spot</code> size.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/test/pages/IllustratedMessage.html
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
</ui5-bar>
</ui5-dialog>

<ui5-illustrated-message id="illustratedMsg2" name="UnableToUpload" title="Something went wrong..." accessible-name-ref="lbl">
<ui5-illustrated-message id="illustratedMsg2" name="UnableToUpload" title="Something went wrong..." accessible-name-ref="lbl" title-level="H6">
<div slot="subtitle">Please try again or contact us at <ui5-link>[email protected]</ui5-link> <br><label id="lbl">Text from aria-labelledby</label></div>
<ui5-button icon="refresh">Try again</ui5-button>
</ui5-illustrated-message>
Expand Down
25 changes: 25 additions & 0 deletions packages/fiori/test/specs/IllustratedMessage.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,31 @@ describe("Accessibility", () => {

});

it("title-level", async () => {
// Arrange
const illustratedMsg = await browser.$("#illustratedMsg2"),
illustratedMsgTitle = await browser.$("#illustratedMsg2").shadow$(".ui5-illustrated-message-root ui5-title"),
EXPECTED_TITLE_lEVEL = "H6",
NEW_TITLE_LEVEL = "H3",
DEFAULT_TITLE_LEVEL = "H2";

// Assert
assert.strictEqual(await illustratedMsgTitle.getAttribute("level"), EXPECTED_TITLE_lEVEL, "level is set");

// Act
await illustratedMsg.setAttribute("title-level", NEW_TITLE_LEVEL);

// Assert
assert.strictEqual(await illustratedMsgTitle.getAttribute("level"), NEW_TITLE_LEVEL, "level is set");

// Act
await illustratedMsg.removeAttribute("title-level");

// Assert
assert.strictEqual(await illustratedMsgTitle.getAttribute("level"), DEFAULT_TITLE_LEVEL, "level has the default value");

});

});

describe("Vertical responsiveness", () => {
Expand Down
8 changes: 8 additions & 0 deletions packages/icons-business-suite/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)

**Note:** Version bump only for package @ui5/webcomponents-icons-business-suite





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents-icons-business-suite
Expand Down
6 changes: 3 additions & 3 deletions packages/icons-business-suite/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-icons-business-suite",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "UI5 Web Components: SAP Fiori Tools icon set",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand All @@ -27,9 +27,9 @@
"directory": "packages/icons-business-suite"
},
"dependencies": {
"@ui5/webcomponents-base": "1.19.0"
"@ui5/webcomponents-base": "1.20.0-rc.0"
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.19.0"
"@ui5/webcomponents-tools": "1.20.0-rc.0"
}
}
8 changes: 8 additions & 0 deletions packages/icons-tnt/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)

**Note:** Version bump only for package @ui5/webcomponents-icons-tnt





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents-icons-tnt
Expand Down
6 changes: 3 additions & 3 deletions packages/icons-tnt/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-icons-tnt",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "UI5 Web Components: SAP Fiori Tools icon set",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand All @@ -27,9 +27,9 @@
"directory": "packages/icons-tnt"
},
"dependencies": {
"@ui5/webcomponents-base": "1.19.0"
"@ui5/webcomponents-base": "1.20.0-rc.0"
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.19.0"
"@ui5/webcomponents-tools": "1.20.0-rc.0"
}
}
8 changes: 8 additions & 0 deletions packages/icons/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)

**Note:** Version bump only for package @ui5/webcomponents-icons





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents-icons
Expand Down
6 changes: 3 additions & 3 deletions packages/icons/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-icons",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "UI5 Web Components: webcomponents.SAP-icons",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand All @@ -27,9 +27,9 @@
"directory": "packages/icons"
},
"dependencies": {
"@ui5/webcomponents-base": "1.19.0"
"@ui5/webcomponents-base": "1.20.0-rc.0"
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.19.0"
"@ui5/webcomponents-tools": "1.20.0-rc.0"
}
}
8 changes: 8 additions & 0 deletions packages/localization/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)

**Note:** Version bump only for package @ui5/webcomponents-localization





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents-localization
Expand Down
2 changes: 1 addition & 1 deletion packages/localization/lib/generate-json-imports/cldr.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import assets from "@ui5/webcomponents-tools/assets-meta.js";
const allLocales = assets.locales.all;

const imports = allLocales.map(locale => `import ${locale} from "../assets/cldr/${locale}.json";`).join("\n");
const caseImports = allLocales.map(locale => `\t\tcase "${locale}": return (await import("../assets/cldr/${locale}.json")).default;`).join("\n");
const caseImports = allLocales.map(locale => `\t\tcase "${locale}": return (await import(/* webpackChunkName: "ui5-webcomponents-cldr-${locale}" */ "../assets/cldr/${locale}.json")).default;`).join("\n");
const localesKeys = allLocales.join(",");
const localesKeysStrArray = allLocales.map(_ => `"${_}"`).join(",");

Expand Down
8 changes: 4 additions & 4 deletions packages/localization/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-localization",
"version": "1.19.0",
"version": "1.20.0-rc.0",
"description": "Localization for UI5 Web Components",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
Expand Down Expand Up @@ -29,13 +29,13 @@
},
"devDependencies": {
"@openui5/sap.ui.core": "1.116.0",
"@ui5/webcomponents-tools": "1.19.0",
"chromedriver": "119.0.0",
"@ui5/webcomponents-tools": "1.20.0-rc.0",
"chromedriver": "117.0.3",
"mkdirp": "^1.0.4",
"resolve": "^1.20.0"
},
"dependencies": {
"@types/openui5": "^1.113.0",
"@ui5/webcomponents-base": "1.19.0"
"@ui5/webcomponents-base": "1.20.0-rc.0"
}
}
12 changes: 12 additions & 0 deletions packages/main/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.20.0-rc.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0...v1.20.0-rc.0) (2023-11-09)


### Bug Fixes

* **ui5-segmented-button:** check for items before applying settings ([#7792](https://github.com/SAP/ui5-webcomponents/issues/7792)) ([7f11274](https://github.com/SAP/ui5-webcomponents/commit/7f112746d50381474ec86da5e428df79c17c6499)), closes [#7788](https://github.com/SAP/ui5-webcomponents/issues/7788)
* **ui5-time-picker:** check value before formatting ([#7793](https://github.com/SAP/ui5-webcomponents/issues/7793)) ([70deda8](https://github.com/SAP/ui5-webcomponents/commit/70deda85293d5e62e99530c9dc0747071d9ee59c)), closes [#7790](https://github.com/SAP/ui5-webcomponents/issues/7790)





# [1.19.0](https://github.com/SAP/ui5-webcomponents/compare/v1.19.0-rc.3...v1.19.0) (2023-11-02)

**Note:** Version bump only for package @ui5/webcomponents
Expand Down
Loading

0 comments on commit 007138e

Please sign in to comment.