refactor(messages)!: Merge no-deprecated-property/parameter into no-d…

…eprecated-api (#324) Also sort all messages alphabetically --------- Co-authored-by: Günter Klatt <[email protected]>
SAP · Sep 27, 2024 · d481334 · d481334
1 parent ac2a5a7
commit d481334
Show file tree

Hide file tree

Showing 11 changed files with 302 additions and 284 deletions.
diff --git a/src/linter/messages.ts b/src/linter/messages.ts
diff --git a/test/lib/linter/rules/snapshots/AsyncComponentFlags.ts.md b/test/lib/linter/rules/snapshots/AsyncComponentFlags.ts.md
diff --git a/test/lib/linter/rules/snapshots/AsyncComponentFlags.ts.snap b/test/lib/linter/rules/snapshots/AsyncComponentFlags.ts.snap
diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap
diff --git a/test/lib/linter/rules/snapshots/NoGlobals.ts.md b/test/lib/linter/rules/snapshots/NoGlobals.ts.md
@@ -110,76 +110,87 @@ Generated by [AVA](https://avajs.dev).
             column: 8,
             line: 8,
             message: 'Access of global variable \'sap\' (sap.m.Button)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 19,
             line: 11,
             message: 'Access of global variable \'sap\' (sap.m)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 14,
             message: 'Access of global variable \'sap\' (sap.ui.requireSync)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 15,
             message: 'Access of global variable \'sap\' (window)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 16,
             message: 'Access of global variable \'sap\' (window.sap.ui.requireSync)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 17,
             message: 'Access of global variable \'sap\' (globalThis.sap.ui.requireSync)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 20,
             message: 'Access of global variable \'sap\' (self.sap.ui.requireSync)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 22,
             message: 'Access of global variable \'sap\' (that.sap.ui.requireSync)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 27,
             message: 'Access of global variable \'sap\' (window)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 29,
             message: 'Access of global variable \'jQuery\' (jQuery.ajax)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },
           {
             column: 4,
             line: 30,
             message: 'Access of global variable \'jQuery\' (jQuery)',
+            messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
             ruleId: 'no-globals',
             severity: 2,
           },

diff --git a/test/lib/linter/rules/snapshots/NoGlobals.ts.snap b/test/lib/linter/rules/snapshots/NoGlobals.ts.snap
diff --git a/test/lib/linter/rules/snapshots/NoPseudoModules.ts.md b/test/lib/linter/rules/snapshots/NoPseudoModules.ts.md
@@ -18,23 +18,23 @@ Generated by [AVA](https://avajs.dev).
           {
             column: 2,
             line: 2,
-            message: 'Deprecated access to enum pseudo module \'sap/ui/core/BarColor\'',
+            message: 'Deprecated access of enum pseudo module \'sap/ui/core/BarColor\'',
             messageDetails: 'Migrating Access to Pseudo Modules (https://ui5.sap.com/#/topic/00737d6c1b864dc3ab72ef56611491c4)',
             ruleId: 'no-pseudo-modules',
             severity: 2,
           },
           {
             column: 2,
             line: 3,
-            message: 'Deprecated access to enum pseudo module \'sap/m/ListSeparators\'',
+            message: 'Deprecated access of enum pseudo module \'sap/m/ListSeparators\'',
             messageDetails: 'Migrating Access to Pseudo Modules (https://ui5.sap.com/#/topic/00737d6c1b864dc3ab72ef56611491c4)',
             ruleId: 'no-pseudo-modules',
             severity: 2,
           },
           {
             column: 2,
             line: 4,
-            message: 'Deprecated access to DataType pseudo module \'sap/ui/core/CSSSize\'',
+            message: 'Deprecated access of DataType pseudo module \'sap/ui/core/CSSSize\'',
             messageDetails: 'Migrating Access to Pseudo Modules (https://ui5.sap.com/#/topic/00737d6c1b864dc3ab72ef56611491c4)',
             ruleId: 'no-pseudo-modules',
             severity: 2,

diff --git a/test/lib/linter/rules/snapshots/NoPseudoModules.ts.snap b/test/lib/linter/rules/snapshots/NoPseudoModules.ts.snap
diff --git a/test/lib/linter/xmlTemplate/snapshots/transpiler.ts.md b/test/lib/linter/xmlTemplate/snapshots/transpiler.ts.md
@@ -708,21 +708,24 @@ Generated by [AVA](https://avajs.dev).
       {
         column: 1,
         line: 8,
-        message: 'Usage of SVG in XML Views/Fragments is deprecated',
+        message: 'Deprecated use of SVG in XML View or Fragment',
+        messageDetails: 'See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
         ruleId: 'no-deprecated-api',
         severity: 2,
       },
       {
         column: 2,
         line: 9,
-        message: 'Usage of SVG in XML Views/Fragments is deprecated',
+        message: 'Deprecated use of SVG in XML View or Fragment',
+        messageDetails: 'See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
         ruleId: 'no-deprecated-api',
         severity: 2,
       },
       {
         column: 3,
         line: 10,
-        message: 'Usage of SVG in XML Views/Fragments is deprecated',
+        message: 'Deprecated use of SVG in XML View or Fragment',
+        messageDetails: 'See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
         ruleId: 'no-deprecated-api',
         severity: 2,
       },

diff --git a/test/lib/linter/xmlTemplate/snapshots/transpiler.ts.snap b/test/lib/linter/xmlTemplate/snapshots/transpiler.ts.snap