test(amdTranspiler): Increase test coverage for multiple returns

SAP · Oct 18, 2024 · 1dc209f · 1dc209f
1 parent 75d2aa8
commit 1dc209f
Show file tree

Hide file tree

Showing 7 changed files with 161 additions and 13 deletions.
diff --git a/...iler/amd/Factory_FunctionVarExpression.js → ...spiler/amd/Factory_FunctionDeclaration.js b/...iler/amd/Factory_FunctionVarExpression.js → ...spiler/amd/Factory_FunctionDeclaration.js
diff --git a/test/fixtures/transpiler/amd/Factory_FunctionDeclarationMultipleReturns.js b/test/fixtures/transpiler/amd/Factory_FunctionDeclarationMultipleReturns.js
@@ -0,0 +1,17 @@
+function factory(Controller, someModule) {
+	const MyController = Controller.extend("MyController", {});
+
+	if (someModule) {
+		return true;
+	} else {
+		return false;
+	}
+}
+
+sap.ui.define(
+	[
+		"sap/ui/core/mvc/Controller",
+		"some/module"
+	],
+	factory
+);
diff --git a/test/fixtures/transpiler/amd/Factory_MultipleReturnsArrowFunction.js b/test/fixtures/transpiler/amd/Factory_MultipleReturnsArrowFunction.js
@@ -0,0 +1,10 @@
+sap.ui.define(["sap/ui/base/Object", "some/module"], (BaseObject, someModule) => {
+
+	BaseObject.extend("my.Class", {});
+
+	if (someModule) {
+		return true;
+	} else {
+		return false;
+	}
+});
diff --git a/...ler/amd/Factory_FunctionVarDeclaration.js → ...ctory_VarDeclarationFunctionExpression.js b/...ler/amd/Factory_FunctionVarDeclaration.js → ...ctory_VarDeclarationFunctionExpression.js
diff --git a/test/fixtures/transpiler/amd/Factory_VarDeclarationFunctionExpressionMultipleReturns.js b/test/fixtures/transpiler/amd/Factory_VarDeclarationFunctionExpressionMultipleReturns.js
@@ -0,0 +1,17 @@
+const factory = function (Controller, someModule) {
+	const MyController = Controller.extend("MyController", {});
+
+	if (someModule) {
+		return true;
+	} else {
+		return false;
+	}
+};
+
+sap.ui.define(
+	[
+		"sap/ui/core/mvc/Controller",
+		"some/module"
+	],
+	factory
+);
diff --git a/test/lib/linter/amdTranspiler/snapshots/transpiler.ts.md b/test/lib/linter/amdTranspiler/snapshots/transpiler.ts.md
@@ -444,7 +444,7 @@ Generated by [AVA](https://avajs.dev).
       version: 3,
     }
 
-## Transpile Factory_FunctionVarDeclaration.js
+## Transpile Factory_FunctionDeclaration.js
 
 > Snapshot 1
 
@@ -453,41 +453,49 @@ Generated by [AVA](https://avajs.dev).
     import "sap/ui/core/routing/History";␊
     export default class MyController_1 extends Controller {␊
     }␊
-    //# sourceMappingURL=Factory_FunctionVarDeclaration.js.map`
+    //# sourceMappingURL=Factory_FunctionDeclaration.js.map`
 
 > Snapshot 2
 
     {
-      file: 'Factory_FunctionVarDeclaration.js',
-      mappings: 'OAA0B,UAAU,MAMlC,4BAA4B;OAC5B,yBAAyB;OACzB,6BAA6B;4CAPvB,UAAU',
+      file: 'Factory_FunctionDeclaration.js',
+      mappings: 'OAAiB,UAAU,MAMzB,4BAA4B;OAC5B,yBAAyB;OACzB,6BAA6B;4CAPvB,UAAU',
       names: [],
       sourceRoot: '',
       sources: [
-        'Factory_FunctionVarDeclaration.js',
+        'Factory_FunctionDeclaration.js',
       ],
       version: 3,
     }
 
-## Transpile Factory_FunctionVarExpression.js
+## Transpile Factory_FunctionDeclarationMultipleReturns.js
 
 > Snapshot 1
 
     `import Controller from "sap/ui/core/mvc/Controller";␊
-    import "sap/ui/core/UIComponent";␊
-    import "sap/ui/core/routing/History";␊
-    export default class MyController_1 extends Controller {␊
+    import someModule from "some/module";␊
+    function factory(Controller, someModule) {␊
+        class MyController extends Controller {␊
+        }␊
+        if (someModule) {␊
+            return true;␊
+        }␊
+        else {␊
+            return false;␊
+        }␊
     }␊
-    //# sourceMappingURL=Factory_FunctionVarExpression.js.map`
+    export default factory(Controller, someModule);␊
+    //# sourceMappingURL=Factory_FunctionDeclarationMultipleReturns.js.map`
 
 > Snapshot 2
 
     {
-      file: 'Factory_FunctionVarExpression.js',
-      mappings: 'OAAiB,UAAU,MAMzB,4BAA4B;OAC5B,yBAAyB;OACzB,6BAA6B;4CAPvB,UAAU',
+      file: 'Factory_FunctionDeclarationMultipleReturns.js',
+      mappings: 'OAAiB,UAAU,MAYzB,4BAA4B;OAZD,UAAU,MAarC,aAAa;AAbf,SAAS,OAAO,CAAC,UAAU,EAAE,UAAU;+BACjB,UAAU;;IAE/B,IAAI,UAAU,EAAE,CAAC;QAChB,OAAO,IAAI,CAAC;IACb,CAAC;SAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACd,CAAC;CACD;eARQ,OAAO,CAAC,UAAU,EAAE,UAAU',
       names: [],
       sourceRoot: '',
       sources: [
-        'Factory_FunctionVarExpression.js',
+        'Factory_FunctionDeclarationMultipleReturns.js',
       ],
       version: 3,
     }
@@ -543,6 +551,37 @@ Generated by [AVA](https://avajs.dev).
       version: 3,
     }
 
+## Transpile Factory_MultipleReturnsArrowFunction.js
+
+> Snapshot 1
+
+    `import BaseObject from "sap/ui/base/Object";␊
+    import someModule from "some/module";␊
+    export default ((BaseObject, someModule) => {␊
+        class Class_1 extends BaseObject {␊
+        }␊
+        if (someModule) {␊
+            return true;␊
+        }␊
+        else {␊
+            return false;␊
+        }␊
+    })(BaseObject, someModule);␊
+    //# sourceMappingURL=Factory_MultipleReturnsArrowFunction.js.map`
+
+> Snapshot 2
+
+    {
+      file: 'Factory_MultipleReturnsArrowFunction.js',
+      mappings: 'OAAsD,UAAU,MAAjD,oBAAoB;OAA+B,UAAU,MAAvC,aAAa;eAAG,CAAA,CAAC,UAAU,EAAE,UAAU,EAAE,EAAE;0BAE/E,UAAU;;IAEV,IAAI,UAAU,EAAE,CAAC;QAChB,OAAO,IAAI,CAAC;IACb,CAAC;SAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACd,CAAC;CACD,CAAA,CATqD,UAAU,EAAE,UAAU',
+      names: [],
+      sourceRoot: '',
+      sources: [
+        'Factory_MultipleReturnsArrowFunction.js',
+      ],
+      version: 3,
+    }
+
 ## Transpile Factory_NotProvided_A.js
 
 > Snapshot 1
@@ -603,6 +642,71 @@ Generated by [AVA](https://avajs.dev).
       version: 3,
     }
 
+## Transpile Factory_VarDeclarationFunctionExpression.js
+
+> Snapshot 1
+
+    `import Controller from "sap/ui/core/mvc/Controller";␊
+    import "sap/ui/core/UIComponent";␊
+    import "sap/ui/core/routing/History";␊
+    export default class MyController_1 extends Controller {␊
+    }␊
+    //# sourceMappingURL=Factory_VarDeclarationFunctionExpression.js.map`
+
+> Snapshot 2
+
+    {
+      file: 'Factory_VarDeclarationFunctionExpression.js',
+      mappings: 'OAA0B,UAAU,MAMlC,4BAA4B;OAC5B,yBAAyB;OACzB,6BAA6B;4CAPvB,UAAU',
+      names: [],
+      sourceRoot: '',
+      sources: [
+        'Factory_VarDeclarationFunctionExpression.js',
+      ],
+      version: 3,
+    }
+
+## Transpile Factory_VarDeclarationFunctionExpressionMultipleReturns.js
+
+> Snapshot 1
+
+    `import Controller from "sap/ui/core/mvc/Controller";␊
+    import someModule from "some/module";␊
+    const factory = function (Controller, someModule) {␊
+        class MyController extends Controller {␊
+        }␊
+        if (someModule) {␊
+            return true;␊
+        }␊
+        else {␊
+            return false;␊
+        }␊
+    };␊
+    export default (function (Controller, someModule) {␊
+        class MyController extends Controller {␊
+        }␊
+        if (someModule) {␊
+            return true;␊
+        }␊
+        else {␊
+            return false;␊
+        }␊
+    }(Controller, someModule));␊
+    //# sourceMappingURL=Factory_VarDeclarationFunctionExpressionMultipleReturns.js.map`
+
+> Snapshot 2
+
+    {
+      file: 'Factory_VarDeclarationFunctionExpressionMultipleReturns.js',
+      mappings: 'OAA0B,UAAU,MAYlC,4BAA4B;OAZQ,UAAU,MAa9C,aAAa;AAbf,MAAM,OAAO,GAAG,UAAU,UAAU,EAAE,UAAU;+BAC1B,UAAU;;IAE/B,IAAI,UAAU,EAAE,CAAC;QAChB,OAAO,IAAI,CAAC;IACb,CAAC;SAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACd,CAAC;CACD,CAAC;gBARc,UAAU,UAAU,EAAE,UAAU;+BAC1B,UAAU;;IAE/B,IAAI,UAAU,EAAE,CAAC;QAChB,OAAO,IAAI,CAAC;IACb,CAAC;SAAM,CAAC;QACP,OAAO,KAAK,CAAC;IACd,CAAC;CACD,CARyB,UAAU,EAAE,UAAU',
+      names: [],
+      sourceRoot: '',
+      sources: [
+        'Factory_VarDeclarationFunctionExpressionMultipleReturns.js',
+      ],
+      version: 3,
+    }
+
 ## Transpile Factory_cond_iife.js
 
 > Snapshot 1

diff --git a/test/lib/linter/amdTranspiler/snapshots/transpiler.ts.snap b/test/lib/linter/amdTranspiler/snapshots/transpiler.ts.snap