Skip to content

Commit

Permalink
Fix/27203/enable context path completion for chart (#677)
Browse files Browse the repository at this point in the history
* fix: contextpath completion enabled for chart

* fix: change set
  • Loading branch information
vadson71 authored Nov 22, 2023
1 parent 4b4acce commit c8768ac
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
7 changes: 7 additions & 0 deletions .changeset/giant-jobs-yawn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@ui5-language-assistant/fe": patch
"vscode-ui5-language-assistant": patch
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
---

contextPath attribute value completion enabled for Chart macros element
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,9 @@ export function contextPathSuggestions({
context.ui5Model
);

// provider is blocked and is used in tests only
// reserved for the future to be reused in binding expressions
if (!(context as unknown as { forTest: boolean }).forTest) {
return [];
}

if (
ui5Property?.library === SAP_FE_MACROS &&
ui5Property.parent?.name === "Chart" &&
ui5Property.name === "contextPath"
) {
const mainServicePath = context.manifestDetails.mainServicePath;
Expand Down

0 comments on commit c8768ac

Please sign in to comment.