revert: remove Theia manifet.json via settings.json workaround (#220)

SAP · Jul 2, 2020 · 4ca8eb9 · 4ca8eb9
1 parent 7ac3471
commit 4ca8eb9
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 152 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,5 +1,2 @@
 # schema.json for manifest
 packages/vscode-ui5-language-assistant/resources/ @sapirpol
-
-# register manifest.json schema in workspace configuration - theia workaround
-packages/vscode-ui5-language-assistant/src/registerManifestSchema.ts @sapirpol @bd82
diff --git a/packages/vscode-ui5-language-assistant/src/extension.ts b/packages/vscode-ui5-language-assistant/src/extension.ts
@@ -10,7 +10,6 @@ import {
   SERVER_PATH,
   ServerInitializationOptions,
 } from "@ui5-language-assistant/language-server";
-import { registerManifestSchema } from "./registerManifestSchema";
 
 let client: LanguageClient;
 
@@ -51,13 +50,6 @@ export async function activate(context: ExtensionContext): Promise<void> {
     clientOptions
   );
 
-  // This is a workaround to config `manifest.json` schema.
-  // Theia has a bug which there is no support for `contributes.jsonValidation`
-  //  - https://code.visualstudio.com/api/references/contribution-points#contributes.jsonValidation
-  if (process.env["THEIA_PARENT_PID"] !== undefined) {
-    registerManifestSchema();
-  }
-
   client.start();
 }
 

diff --git a/packages/vscode-ui5-language-assistant/src/manifestSchemaConfig.ts b/packages/vscode-ui5-language-assistant/src/manifestSchemaConfig.ts
diff --git a/packages/vscode-ui5-language-assistant/src/registerManifestSchema.ts b/packages/vscode-ui5-language-assistant/src/registerManifestSchema.ts
diff --git a/packages/vscode-ui5-language-assistant/test/unit/registerManifestSchema-spec.ts b/packages/vscode-ui5-language-assistant/test/unit/registerManifestSchema-spec.ts