Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iframe parameter to security settings #907

Merged
merged 13 commits into from
Sep 24, 2024
Merged

Conversation

lechnerc77
Copy link
Member

@lechnerc77 lechnerc77 commented Sep 19, 2024

Purpose

  • The parameter iframe_domains was added to the resources and data sources for security settings to be in sync with the BTP CLI
  • The resources for security settings can now be imported
  • According updates of the documentation and test cases
  • closes [FEATURE] Trusted Domains in Subaccount are not added #904

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

Due to the make fmt some files have been formated that are not subject to the change

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 changed the title feat: add ifrmae parameter to security settings feat: add iframe parameter to security settings Sep 19, 2024
@lechnerc77
Copy link
Member Author

Drift detection error is okay, as the test fixtures for the resources and data sources had to be re-recorded

@lechnerc77 lechnerc77 added this to the 1.7.0 milestone Sep 19, 2024
@lechnerc77 lechnerc77 added the enhancement New feature or request label Sep 19, 2024
@lechnerc77 lechnerc77 self-assigned this Sep 19, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) September 19, 2024 09:33
@diya-dhan
Copy link
Contributor

In the files examples/resources/btp_globalaccount_security_settings/resource.tf and examples/resources/btp_subaccount_security_settings/resource.tf, the attribute iframe_domains is a shown as a list although the attribute is a string as per the schema.

image image

@diya-dhan
Copy link
Contributor

In the file internal/provider/datasource_globalaccount_security_settings.go and internal/provider/datasource_globalaccount_security_settings_test.go, the attribute iframe_domains is configured as Optional as well as Computed. This is being reflected in the documentation as well.

@lechnerc77
Copy link
Member Author

In the files examples/resources/btp_globalaccount_security_settings/resource.tf and examples/resources/btp_subaccount_security_settings/resource.tf, the attribute iframe_domains is a shown as a list although the attribute is a string as per the schema.

image image

Resolved

@lechnerc77
Copy link
Member Author

In the file internal/provider/datasource_globalaccount_security_settings.go and internal/provider/datasource_globalaccount_security_settings_test.go, the attribute iframe_domains is configured as Optional as well as Computed. This is being reflected in the documentation as well.

Fixed

@lechnerc77 lechnerc77 enabled auto-merge (squash) September 24, 2024 05:54
@lechnerc77 lechnerc77 enabled auto-merge (squash) September 24, 2024 06:49
@diya-dhan
Copy link
Contributor

Drift detection can be ignored as fixtures were re-recorded

@diya-dhan
Copy link
Contributor

Tested out changes, everything works fine

Copy link
Contributor

@diya-dhan diya-dhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine, testing done as well

@lechnerc77 lechnerc77 merged commit fa69c8d into main Sep 24, 2024
14 of 15 checks passed
@lechnerc77 lechnerc77 deleted the feat/iframe branch September 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Trusted Domains in Subaccount are not added
2 participants