Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resource to manage XSUAA Api Credentials #893

Merged
merged 32 commits into from
Aug 26, 2024
Merged

feat: Resource to manage XSUAA Api Credentials #893

merged 32 commits into from
Aug 26, 2024

Conversation

diya-dhan
Copy link
Contributor

@diya-dhan diya-dhan commented Aug 25, 2024

Purpose

fix #689

The BTP CLI supports managing API credentials for the SAP Authorization and Trust Management (XSUAA) service, enabling users to interact programmatically with REST APIs. These APIs facilitate the management of entities and user provisioning across subaccounts, global accounts, or directories.

The provider now has introduced new resources to manage these API credentials at various levels: subaccount, global account, and directory. Users can create credentials of either the certificate type (currently, certificates can only be provided as strings) or the secret type. The state file will store the client secret or certificate key information for reference when using these APIs.

Please note that updating credentials is not supported by this resource, as there is currently no API available for this purpose.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@diya-dhan diya-dhan added the enhancement New feature or request label Aug 25, 2024
@diya-dhan diya-dhan added this to the 1.6.0 milestone Aug 25, 2024
@diya-dhan diya-dhan self-assigned this Aug 25, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) August 26, 2024 06:25
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested for import documentation

General question: there are no data sources available. This is due to the fact that the returned data is only a fraction of the complete data and we leave it out?

@lechnerc77
Copy link
Member

Sonar Cloud Quality check is accepted to be below 80%

@diya-dhan
Copy link
Contributor Author

Some minor changes requested for import documentation

General question: there are no data sources available. This is due to the fact that the returned data is only a fraction of the complete data and we leave it out?

Yes, like you mentioned the GET call does not return a lot of the information that is relevant to the user. This is only known at the time the api credentials are created. Additionally, as of now, there is no use case where the api credentials can be used in other BTP resources, due to which a datasource for it didn't really make sense.

Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit 6807059 into main Aug 26, 2024
14 of 15 checks passed
@lechnerc77 lechnerc77 deleted the issue_689 branch August 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Managing API Credentials for Calling REST APIs of SAP Authorization and Trust Management Service
2 participants