-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resource to manage XSUAA Api Credentials #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested for import documentation
General question: there are no data sources available. This is due to the fact that the returned data is only a fraction of the complete data and we leave it out?
Sonar Cloud Quality check is accepted to be below 80% |
Yes, like you mentioned the GET call does not return a lot of the information that is relevant to the user. This is only known at the time the api credentials are created. Additionally, as of now, there is no use case where the api credentials can be used in other BTP resources, due to which a datasource for it didn't really make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Purpose
fix #689
The BTP CLI supports managing API credentials for the SAP Authorization and Trust Management (XSUAA) service, enabling users to interact programmatically with REST APIs. These APIs facilitate the management of entities and user provisioning across subaccounts, global accounts, or directories.
The provider now has introduced new resources to manage these API credentials at various levels: subaccount, global account, and directory. Users can create credentials of either the certificate type (currently, certificates can only be provided as strings) or the secret type. The state file will store the client secret or certificate key information for reference when using these APIs.
Please note that updating credentials is not supported by this resource, as there is currently no API available for this purpose.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
go test ./...
What to Check
Verify that the following are valid:
Checklist for reviewer
The following organizational tasks must be completed before merging this PR: