Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework devcontainer setup #891

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

  • Remove the automatic install of xdg-utils due to failures in the devcontainer setup
  • Add comment on SSo setup in devcontainer file

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: rework dev container setup

How to Test

  • Start the devcontainer

What to Check

Verify that the following are valid:

  • The devcontainer starts without errors

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added this to the 1.6.0 milestone Aug 22, 2024
@lechnerc77 lechnerc77 added dependencies Pull requests that update a dependency file ignore-for-release All things not to be mentioned in release notes labels Aug 22, 2024
@lechnerc77 lechnerc77 self-assigned this Aug 22, 2024
@vipinvkmenon vipinvkmenon merged commit 5f29955 into main Aug 22, 2024
15 checks passed
@vipinvkmenon vipinvkmenon deleted the chore/dev-container-setup branch August 22, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ignore-for-release All things not to be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants