Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed variable idp from regression tests #868

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

diya-dhan
Copy link
Contributor

Purpose

Temporary fix for the regression tests.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@vipinvkmenon vipinvkmenon merged commit dace8d9 into main Jul 24, 2024
13 checks passed
@vipinvkmenon vipinvkmenon deleted the regressionTestFix branch July 24, 2024 08:26
@vipinvkmenon vipinvkmenon added the ignore-for-release All things not to be mentioned in release notes label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release All things not to be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants