-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dashboard URL to service instance #865
Conversation
Regression test done with HANA Cloud that exposes the dashboard URL- due to computed field, change has no impact on existing states. Customers can fetch the additional computed field via Here is the sample configuration used to validate the setup:
terraform {
required_providers {
btp = {
source = "SAP/btp"
version = "~>1.4.0"
}
}
}
# Configure the BTP Provider
provider "btp" {
globalaccount = var.globalaccount
cli_server_url = var.cli_server_url
}
resource "btp_subaccount" "sa_retest_hana_cloud" {
name = "retest-hana-cloud"
subdomain = "retest-hana-cloud"
region = var.region
}
resource "btp_subaccount_entitlement" "se_hana-cloud" {
subaccount_id = resource.btp_subaccount.sa_retest_hana_cloud.id
service_name = "hana-cloud"
plan_name = "hana"
}
data "btp_subaccount_service_plan" "sp_hana_cloud__hana" {
subaccount_id = resource.btp_subaccount.sa_retest_hana_cloud.id
offering_name = "hana-cloud"
name = "hana"
depends_on = [btp_subaccount_entitlement.se_hana-cloud]
}
resource "btp_subaccount_service_instance" "hana_cloud_hana_instance" {
subaccount_id = resource.btp_subaccount.sa_retest_hana_cloud.id
serviceplan_id = data.btp_subaccount_service_plan.sp_hana_cloud__hana.id
name = "hana-cloud-test-tf"
parameters = jsonencode({
"data" = {
"memory" = 32
"generateSystemPassword" = true
"edition" = "cloud"
}
})
timeouts = {
create = "25m"
update = "15m"
delete = "15m"
}
}
variable "globalaccount" {
description = "The global account name"
type = string
default = <YOUR GLOBAL ACCOUNT SUBDOMAIN>
}
variable "cli_server_url" {
description = "The BTP CLI server URL"
type = string
default = "https://cli.btp.cloud.sap"
}
variable "region" {
description = "The region where the subaccount should be created"
type = string
default = "us10"
} |
|
@vipinvkmenon @CHERIANS: when doing the review, please also validate the regression e.g. via the sample configuration provided above. |
Verified |
Purpose
dashboard_url
as computed parameter to the resource and data source for service instancedashboard_url
property tobtp_subaccount_service_instance
Resource and Data Source #864Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
go test ./...
What to Check
Verify that the following are valid:
Other Information
n/a
Checklist for reviewer
The following organizational tasks must be completed before merging this PR: