Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: timeout for test runs #861

Merged
merged 2 commits into from
Jul 22, 2024
Merged

chore: timeout for test runs #861

merged 2 commits into from
Jul 22, 2024

Conversation

lechnerc77
Copy link
Member

Purpose

  • Increase timeout limit for tests to safeguard against long running test recordings (like service instance)

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: test setup

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • Tests do not timeout

Other Information

As we cannot automatically cleanup the test fixtures this increase of the timeout safeguards the test runs against timeouts esp. for relases

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 self-assigned this Jul 22, 2024
@lechnerc77 lechnerc77 added test-setup Setup of integration tests ignore-for-release All things not to be mentioned in release notes labels Jul 22, 2024
@lechnerc77 lechnerc77 added this to the 1.5.0 milestone Jul 22, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 22, 2024 05:47
Copy link
Contributor

@CHERIANS CHERIANS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lechnerc77 lechnerc77 merged commit 1af0069 into main Jul 22, 2024
15 checks passed
@lechnerc77 lechnerc77 deleted the chore/test-timeout branch July 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release All things not to be mentioned in release notes test-setup Setup of integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants