-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resource to create roles #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests for the UPDATE
and IMPORT
operations should be added to the test cases to ensure that we cover all available operations in the tests.
In addition, I think the test cases need to be re-recorded as they currently run into errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Purpose
Added role-specific resources in the provider for directory, global account, and subaccount.
This PR will resolve issue #841
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
go test ./...
What to Check
Verify that the following are valid:
Other Information
Checklist for reviewer
The following organizational tasks must be completed before merging this PR: