Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resource to create roles #858

Merged
merged 8 commits into from
Jul 22, 2024
Merged

feat: Resource to create roles #858

merged 8 commits into from
Jul 22, 2024

Conversation

ANUGRAHG
Copy link
Member

@ANUGRAHG ANUGRAHG commented Jul 19, 2024

Purpose

Added role-specific resources in the provider for directory, global account, and subaccount.
This PR will resolve issue #841

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@ANUGRAHG ANUGRAHG added the enhancement New feature or request label Jul 19, 2024
@ANUGRAHG ANUGRAHG added this to the 1.5.0 milestone Jul 19, 2024
@ANUGRAHG ANUGRAHG self-assigned this Jul 19, 2024
@ANUGRAHG ANUGRAHG linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for the UPDATE and IMPORT operations should be added to the test cases to ensure that we cover all available operations in the tests.

In addition, I think the test cases need to be re-recorded as they currently run into errors.

@ANUGRAHG ANUGRAHG requested a review from lechnerc77 July 22, 2024 10:31
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit 51ac0dc into main Jul 22, 2024
15 checks passed
@lechnerc77 lechnerc77 deleted the issue-841 branch July 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Resource to create 'role' in subaccount
3 participants