Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increased timeout for resource subaccount subscription #856

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

diya-dhan
Copy link
Contributor

@diya-dhan diya-dhan commented Jul 17, 2024

Purpose

This PR provides a temporal workaround for #848

The timeout for subaccount application subscriptions has been increased from 10 minutes to 60 minutes to accommodate scenarios where the subscription process may take longer.

Instead of making the timeout a configurable parameter in the resource, the values for the Create and Delete functions were adjusted to avoid a schema change..

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@diya-dhan diya-dhan added the enhancement New feature or request label Jul 17, 2024
@diya-dhan diya-dhan added this to the 1.5.0 milestone Jul 17, 2024
@diya-dhan diya-dhan self-assigned this Jul 17, 2024
@diya-dhan diya-dhan changed the title feature: increased timeout for resource subaccount subscription feat: increased timeout for resource subaccount subscription Jul 17, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 17, 2024 08:35
@lechnerc77 lechnerc77 merged commit d78a61a into main Jul 17, 2024
20 of 22 checks passed
@lechnerc77 lechnerc77 deleted the issue_848 branch July 17, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants