Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for multiple auth parameters #854

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: check for multiple auth parameters #854

merged 1 commit into from
Jul 19, 2024

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
Provide username/password as well as the ID Token (random value) via ENV variables
Execute a terraform plan

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • An error message is raised when the additional test step is executed

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 self-assigned this Jul 16, 2024
@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 16, 2024
@lechnerc77 lechnerc77 added this to the 1.5.0 milestone Jul 16, 2024
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 16, 2024 13:00
Copy link
Contributor

@CHERIANS CHERIANS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@lechnerc77 lechnerc77 merged commit 6f078e8 into main Jul 19, 2024
15 checks passed
@lechnerc77 lechnerc77 deleted the fix/issue-853 branch July 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] BTP_IDTOKEN silently takes precedence even when username and password are provided
2 participants