Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move guides to the templates #818

Closed
wants to merge 1 commit into from
Closed

Conversation

vipinvkmenon
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test

n/a

  • Additional test steps

n/a

What to Check

Verify that the following are valid:

n/a

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this setup resembles a legacy setup. We kept the guides separate by intention to be able to make changes without pushing new releases of the provider.

Referencing the guides from the main page of the registry pointing to this repository

@@ -6,18 +6,15 @@ The Terraform provider for SAP BTP enables you to automate the provisioning, man

## Prerequisites

To follow along with this tutorial, ensure you have access to a [free BTP trial account](https://developers.sap.com/tutorials/hcp-create-trial-account.html) and Terraform installed on your machine. You can download it from the official [Terraform website](https://developer.hashicorp.com/terraform/downloads).
To follow along with this tutorial, ensure you have access to a [free BTP trial account](hcp-create-trial-account) and Terraform installed on your machine. You can download it from the official [Terraform website](https://developer.hashicorp.com/terraform/downloads).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be excluded from the lychee setup

@vipinvkmenon
Copy link
Member Author

I think we can keep it in that approach itself then. As long as we have a pointer to the guides from the main page that'll do. I can close this PR then.

@lechnerc77
Copy link
Member

As everything is available at https://registry.terraform.io/providers/SAP/btp/latest/docs I will close the PR as proposed.

@lechnerc77 lechnerc77 closed this May 13, 2024
@lechnerc77 lechnerc77 deleted the docs-guides branch May 13, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants