Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable timeouts for environment instance and service instance #401

Merged
merged 9 commits into from
Sep 4, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

We restrict the current configurability to the resources subaccount_environment_instance and subaccount_service_instance as they have the largest range of time needed for the create, update and delete operations. In case of customer feedback we can transfer it to further resources
This avoids unnecessary duplication of the datatypes for the data sources.

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the enhancement New feature or request label Sep 1, 2023
@lechnerc77 lechnerc77 self-assigned this Sep 1, 2023
@lechnerc77 lechnerc77 changed the title Feat configurable timeouts Feat: configurable timeouts Sep 1, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) September 1, 2023 11:25
@lechnerc77 lechnerc77 changed the title Feat: configurable timeouts feat: configurable timeouts Sep 1, 2023
Copy link
Member

@v0lkc v0lkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor finding with the formatting, otherwise good!

@lechnerc77 lechnerc77 merged commit 5bb0695 into main Sep 4, 2023
14 of 16 checks passed
@lechnerc77 lechnerc77 deleted the feat-configurable-timeouts branch September 4, 2023 08:51
@lechnerc77 lechnerc77 changed the title feat: configurable timeouts feat: configurable timeouts for environment instance and service instance Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Configurable timeout for resources
2 participants