Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(btp_subaccount_roles): mapping of role names #350

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(btp_subaccount_roles): mapping of role names #350

merged 1 commit into from
Jul 28, 2023

Conversation

v0lkc
Copy link
Member

@v0lkc v0lkc commented Jul 28, 2023

Purpose

Fixes #349

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@v0lkc v0lkc changed the title fix: mapping of role names fix(btp_subaccount_roles): mapping of role names Jul 28, 2023
@v0lkc v0lkc requested a review from lechnerc77 July 28, 2023 11:20
@v0lkc v0lkc enabled auto-merge (squash) July 28, 2023 11:28
@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 28, 2023
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v0lkc v0lkc merged commit 6beb2f0 into main Jul 28, 2023
14 checks passed
@v0lkc v0lkc deleted the fix/349 branch July 28, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] role name wrongly mapped in datasource btp_subaccount_roles
2 participants