Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource): fix schema and add tests for resource provider #339

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

kuntzed
Copy link
Contributor

@kuntzed kuntzed commented Jul 27, 2023

Purpose

The schema for the resource provider resource and datasources is fixed and corresponding tests are added. Furthermore, some attribute names were improved.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Resolves #337

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

The schema for the resource provider resource and datasources is
fixed and corresponding tests are added. Furthermore, some attribute
names were improved.

Resolves #337
@kuntzed kuntzed requested a review from lechnerc77 July 27, 2023 11:14
@kuntzed kuntzed self-assigned this Jul 27, 2023
@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 27, 2023
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit c9669f3 into main Jul 27, 2023
18 checks passed
@lechnerc77 lechnerc77 deleted the issue337 branch July 27, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource and data sources for "globalaccount_resource_provider" - Fix schema and add missing tests
2 participants