Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: docs for new datasources and resources #325

Merged
merged 1 commit into from
Jul 25, 2023
Merged

docs: docs for new datasources and resources #325

merged 1 commit into from
Jul 25, 2023

Conversation

annawenger20
Copy link
Contributor

@annawenger20 annawenger20 commented Jul 25, 2023 •
edited by lechnerc77
Loading

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation (content) changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 changed the title reviewed docs for new datasources and resources feat: docs for new datasources and resources Jul 25, 2023
@lechnerc77 lechnerc77 added the documentation Improvements or additions to documentation label Jul 25, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 25, 2023
@lechnerc77 lechnerc77 changed the title feat: docs for new datasources and resources docs: docs for new datasources and resources Jul 25, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 25, 2023 12:22
lechnerc77
lechnerc77 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit 92b9844 into main Jul 25, 2023
13 of 14 checks passed
@lechnerc77 lechnerc77 deleted the doc-review-new-resources-and-datasources branch July 25, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

Assignees

@annawenger20 annawenger20

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.2.0-beta1 - July release
Development

Successfully merging this pull request may close these issues.

Review of updated/new documentation
2 participants
@annawenger20 @lechnerc77