Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polling service instances (delete) #319

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

This PR adds the missing polling when deleting a service instance

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Test are executed successfully

Other Information

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 24, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 24, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 24, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 24, 2023 13:12
@lechnerc77 lechnerc77 requested a review from v0lkc July 25, 2023 06:41
@lechnerc77
Copy link
Member Author

Test Coverage of new code below 80% (overall coverage estimated after merge 87.3%): missing coverage comes from error branches in destroy that cannot be easily triggered via plugin test framework afaik. As coverage is still above 85% after merge the merge of the PR should be acceptable.

@rui1610 rui1610 requested review from rui1610 and removed request for v0lkc July 25, 2023 14:24
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@lechnerc77 lechnerc77 merged commit c412b8d into main Jul 25, 2023
12 of 13 checks passed
@lechnerc77 lechnerc77 deleted the fix-polling-services-delete branch July 25, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants