Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing planmodifier to the computed IDs #306

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: added missing planmodifier to the computed IDs #306

merged 1 commit into from
Jul 20, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

  • Add planmodifier stringplanmodifier.UseStateForUnknown(), for computed ID fields to ensure a consistent handling of the field especially during update operations

Closes #300

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Test execution succeeds

Other Information

Removed unnecessary comment from subaccount resource as part of PR

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 20, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 20, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 20, 2023
@lechnerc77 lechnerc77 requested a review from kuntzed July 20, 2023 10:16
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 20, 2023 10:17
@lechnerc77 lechnerc77 merged commit fbb7fee into main Jul 20, 2023
10 checks passed
@lechnerc77 lechnerc77 deleted the align-computed-ids branch July 20, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuntzed kuntzed kuntzed approved these changes

Assignees

@lechnerc77 lechnerc77

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0-beta1 - July release
Development

Successfully merging this pull request may close these issues.

[BUG] Computed IDs - modifier
2 participants
@lechnerc77 @kuntzed