Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): support update of subaccount entitlements #304

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

kuntzed
Copy link
Contributor

@kuntzed kuntzed commented Jul 20, 2023

Purpose

support update of subaccount entitlements

Also: fix validation of "amount" and corresponding test to prevent
quota being actively set to 0, which results in deletion and
an inconsistent state.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

tests ok

Other Information

Resolves #101

Also: fix validation of "amount" and corresponding test to prevent
      quota being actively set to 0, which results in deletion and
      an inconsistent state.

Resolves #101
@kuntzed kuntzed requested a review from lechnerc77 July 20, 2023 08:17
@kuntzed kuntzed self-assigned this Jul 20, 2023
@kuntzed kuntzed enabled auto-merge (squash) July 20, 2023 08:18
@lechnerc77 lechnerc77 added the enhancement New feature or request label Jul 20, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 20, 2023
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice refactoring

@kuntzed kuntzed merged commit f01e359 into main Jul 20, 2023
13 checks passed
@kuntzed kuntzed deleted the issue101 branch July 20, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource "subaccount_entitlement" - Support Update Operation
2 participants