Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update service instance failure - resource not found #301

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

  • This PR contains the logic to consider the async update operation of the service manager
  • This PR implements workarounds to mitigate shortcomings of the Service Manager API (temporal fix)

Close #298

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe: workaround for downstream errors (service manager)

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Test are executed successfully

Other Information

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 19, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 19, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 19, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 19, 2023 10:57
@lechnerc77 lechnerc77 requested a review from v0lkc July 19, 2023 12:29
@lechnerc77
Copy link
Member Author

@v0lkc : Kindly ignore the Sonar Cloud issue: due to the workaround we would need to adjust a lot in the testing to reflect the weird setup we need to implement to get things running. As this is a temporal workaround it is not reasonable to put effort in this test enhancement

@lechnerc77 lechnerc77 merged commit 283b929 into main Jul 20, 2023
12 of 13 checks passed
@lechnerc77 lechnerc77 deleted the fix-update-service-instance branch July 20, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Update operation of service instance
2 participants