Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resource): support role collection update #299

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat(resource): support role collection update #299

merged 1 commit into from
Jul 18, 2023

Conversation

kuntzed
Copy link
Contributor

@kuntzed kuntzed commented Jul 18, 2023

Purpose

Add support for update operation to role collection facade and resources

Also: Fix error message when adding roles to role-collection

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

Tests are green

Other Information

Resolves #86
Resolves #99
Resolves #102

@kuntzed
feature(resource): support role collection update
ade282c 
Add support for update operation to role collection facade and resources

Also: Fix error message when adding roles to role-collection

Resolves #86
Resolves #99
Resolves #102
@kuntzed kuntzed self-assigned this Jul 18, 2023
@lechnerc77 lechnerc77 changed the title feature(resource): support role collection update feat(resource): support role collection update Jul 18, 2023
@lechnerc77 lechnerc77 added the enhancement New feature or request label Jul 18, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 18, 2023
@lechnerc77 lechnerc77 mentioned this pull request Jul 18, 2023
Closed
lechnerc77
lechnerc77 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lechnerc77 lechnerc77 merged commit 482784e into main Jul 18, 2023
13 of 14 checks passed
@lechnerc77 lechnerc77 deleted the issue86_99_102 branch July 18, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lechnerc77 lechnerc77 lechnerc77 approved these changes

Assignees

@kuntzed kuntzed

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0-beta1 - July release
2 participants
@kuntzed @lechnerc77