Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reprioritized FIXME comments #287

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: reprioritized FIXME comments #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19416f4
fix: reprioritized FIXME comments
lechnerc77 Jul 12, 2023
fbde2b8
fix: typo
lechnerc77 Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/btpcli/facade_accounts_subscription.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func (f *accountsSubscriptionFacade) getCommand() string {
}

func (f *accountsSubscriptionFacade) List(ctx context.Context, subaccountId string) ([]saas_manager_service.EntitledApplicationsResponseObject, CommandResponse, error) {
type wrapper struct { // FIXME should be in types package
type wrapper struct { // TODO should be in types package
Applications []saas_manager_service.EntitledApplicationsResponseObject `json:"applications"`
}

Expand Down
2 changes: 1 addition & 1 deletion internal/btpcli/types/xsuaa_authz/model_user_reference.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type UserReference struct {
FamilyName string `json:"familyName,omitempty"`
Origin string `json:"origin,omitempty"`

// FIXME additional fields not mentioned in the swagger file
// TODO additional fields not mentioned in the swagger file
Verified bool `json:"verified,omitempty"`
LegacyVerificationBehavior bool `json:"legacyVerificationBehavior,omitempty"`
PasswordChangeRequired bool `json:"passwordChangeRequired,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion internal/tfutils/tfutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func ToBTPCLIParamsMap(a any) (map[string]string, error) {
}

value = field.Elem().Interface().(string)
case "map[string][]string": // FIXME would be nice to have `enodethisasjson` tag, instead of an explicit typemapping
case "map[string][]string": // TODO would be nice to have `encodethisasjson` tag, instead of an explicit type mapping

if field.IsNil() {
continue
Expand Down
Loading