Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong error message in update of directory resource #286

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: wrong error message in update of directory resource #286

merged 1 commit into from
Jul 12, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

  • Correction of Sonar Cloud Codesmell concerning error message in resource_directory.go (Link>)
  • was indeed a bug (wrong error message in update case)

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Test are successful

Other Information

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 12, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 12, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 12, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 12, 2023 12:22
@lechnerc77 lechnerc77 requested a review from kuntzed July 12, 2023 12:22
@lechnerc77 lechnerc77 added the sonar cloud finding Finding from Sonar Cloud quality checks label Jul 12, 2023
kuntzed
kuntzed approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@kuntzed kuntzed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, this was spotted by sonar? Nice.

@lechnerc77 lechnerc77 merged commit 37042c6 into main Jul 12, 2023
13 checks passed
@lechnerc77 lechnerc77 deleted the fix-codesmell-duplicate-strings branch July 12, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuntzed kuntzed kuntzed approved these changes

Assignees

@lechnerc77 lechnerc77

Labels
bug Something isn't working sonar cloud finding Finding from Sonar Cloud quality checks
Projects
None yet
Milestone
0.2.0-beta1 - July release
Development

Successfully merging this pull request may close these issues.
2 participants
@lechnerc77 @kuntzed