Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add service binding resources and data sources #285

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

lechnerc77
Copy link
Member

@lechnerc77 lechnerc77 commented Jul 12, 2023

Purpose

  • This PR adds the resources and data sources needed for the service bindings in SAP BTP
  • It contains the corresponding tests and recorded test fixtures
  • documentation is updated

Closes #231 and #235

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Test succeed

Other Information

As a side-effect from recording the fixtures, the provider_test.go was enhanced to remove client IDs and client secrets from the recordings

@lechnerc77 lechnerc77 added the enhancement New feature or request label Jul 12, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 12, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 12, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 12, 2023 11:53
@lechnerc77 lechnerc77 requested a review from v0lkc July 12, 2023 11:54
@lechnerc77 lechnerc77 changed the title feat: add service binding rsources and data sources feat: add service binding resources and data sources Jul 13, 2023
@lechnerc77 lechnerc77 merged commit 1025f63 into main Jul 19, 2023
5 checks passed
@lechnerc77 lechnerc77 deleted the feat-service-binding branch July 19, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants