Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resource): support directory update #284

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat(resource): support directory update #284

merged 1 commit into from
Jul 10, 2023

Conversation

kuntzed
Copy link
Contributor

@kuntzed kuntzed commented Jul 10, 2023

Purpose

Add support for update operation to directory facade and resource

Also: add Globalaccount property to DirectoryCreateInput

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the tests run successful

Other Information

Resolves #88

Add support for update operation to directory facade and resource

Also: add Globalaccount property to DirectoryCreateInput

Resolves #88
@kuntzed kuntzed requested a review from lechnerc77 July 10, 2023 11:58
@kuntzed kuntzed self-assigned this Jul 10, 2023
@lechnerc77 lechnerc77 changed the title feature(resource): support directory update feat(resource): support directory update Jul 10, 2023
@lechnerc77 lechnerc77 merged commit 05c0365 into main Jul 10, 2023
13 of 14 checks passed
@lechnerc77 lechnerc77 deleted the issue88 branch July 10, 2023 12:05
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lechnerc77 lechnerc77 added the enhancement New feature or request label Jul 10, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource "directory" - Support Update Operation
2 participants