Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct subaccount test recording #283

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: correct subaccount test recording #283

merged 1 commit into from
Jul 10, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

  • Fix recording of fixture for subaccount
  • fixing error of update operation not found

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Tests succeed

Other Information

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 10, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 10, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 10, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 10, 2023 08:42
rui1610
rui1610 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit fa23333 into main Jul 10, 2023
13 checks passed
@lechnerc77 lechnerc77 deleted the fix-subaccount-recording branch July 10, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rui1610 rui1610 rui1610 approved these changes

Assignees

@lechnerc77 lechnerc77

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0-beta1 - July release
Development

Successfully merging this pull request may close these issues.
2 participants
@lechnerc77 @rui1610