Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data sources for and needed for service instances #281

Merged
merged 9 commits into from
Jul 10, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Check that tests pass

Other Information

n/a

@lechnerc77 lechnerc77 added the enhancement New feature or request label Jul 7, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 7, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 7, 2023
@lechnerc77
Copy link
Member Author

Inclusive language warnings come from recordings of service manager requests - nothing can be fixed in our code

@lechnerc77 lechnerc77 enabled auto-merge (squash) July 7, 2023 13:16
@lechnerc77 lechnerc77 requested a review from v0lkc July 7, 2023 13:16
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Went through all the files except for the md files of the documentation.

@lechnerc77 lechnerc77 merged commit 2540f83 into main Jul 10, 2023
13 checks passed
@lechnerc77 lechnerc77 deleted the service-instance-ds branch July 10, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasource "datasource_subaccount_service_instance(s)" - Add to released datasources
2 participants