Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update subaccount with missing fields #279

Merged
merged 3 commits into from
Jul 9, 2023
Merged

fix: update subaccount with missing fields #279

merged 3 commits into from
Jul 9, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code
go test ./...

What to Check

Verify that the following are valid

  • Test execution succeeds

Other Information

The use for production flag is excluded - tracked via #273

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 6, 2023
@lechnerc77 lechnerc77 added this to the 0.2.0-beta1 - July release milestone Jul 6, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 6, 2023
@lechnerc77 lechnerc77 linked an issue Jul 6, 2023 that may be closed by this pull request
[BUG]: Provider produced inconsistent result after apply when changing the description of a subaccount #278
Closed
1 task
@lechnerc77 lechnerc77 requested a review from v0lkc July 6, 2023 08:53
@lechnerc77 lechnerc77 changed the title Fix: update subaccount fix: update subaccount Jul 6, 2023
@lechnerc77 lechnerc77 changed the title fix: update subaccount fix: update subaccount with missing fields Jul 6, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 7, 2023 08:01
rui1610
rui1610 approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit b33f08b into main Jul 9, 2023
13 checks passed
@lechnerc77 lechnerc77 deleted the fix-update-subaccount branch July 9, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rui1610 rui1610 rui1610 approved these changes

@v0lkc v0lkc Awaiting requested review from v0lkc

Assignees

@lechnerc77 lechnerc77

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0-beta1 - July release
Development

Successfully merging this pull request may close these issues.

[BUG]: Provider produced inconsistent result after apply when changing the description of a subaccount
2 participants
@lechnerc77 @rui1610