[FEATURE] Configurable timeout for resources

[lechnerc77]

After phase 1 the Timeouts in the Terraform provider resources are hard coded. These timeouts should be made configurable.
This also comprises a discussion around SLAs.

[lechnerc77]

Essential for Kyma Environment

[lechnerc77]

Additional information:

• See https://developer.hashicorp.com/terraform/plugin/framework/resources/timeouts
• https://github.com/hashicorp/terraform-plugin-framework-timeouts
• Example: https://github.com/EnterpriseDB/terraform-provider-biganimal/blob/edcae8de9e35511f4a6b1ed488da267bbb932c9d/pkg/provider/resource_region.go

[lechnerc77]

Resources that need to be targeted for configurable timeouts (resource + command that needs to be enhanced)

Resource	CREATE	UPDATE	DELETE
resource_directory	✅	✅	✅
resource_subaccount_entitlement	✅	✅	✅
resource_subaccount_environment_instance	✅	✅	✅
resource_subaccount_service_binding	✅	n/a	✅
resource_subaccount_service_instance	✅	✅	✅
resource_subaccount_subscription	✅	n/a	✅
resource_subaccount	✅	✅	✅

Depends on #293 to have polling implemented consistently

[lechnerc77]

Additional remark: As we can only specify timeouts but not the Delay or MinTimeOut w must calculate these values based on the configurable timeout value

[lechnerc77]

Work started in branch feat-configurable-timeouts, namely:

• enhancement of schema and create for resource environment_instance with timeout
• addition of helper method to calculate polling interval etc. based on timeout

[aydin-ozcan]

Hi @lechnerc77 ,
Will the timeouts going to be effective both ways ?
On destruction of kyma , I get the timeout again .

btp_subaccount_environment_instance.kyma: Still destroying... [id=B63CBFF5-4970-4C97-8186-DA21FDA2DF2A, 10m0s elapsed]
╷
│ Error: API Error Deleting Resource Environment Instance (Subaccount)
│
│ timeout while waiting for state to become 'DELETED, DELETION_FAILED' (last state: 'DELETING', timeout: 10m0s)

[v0lkc]

Hi @aydin-ozcan,

yes this will have impact on all operations (create, delete, ...).

Best,
Chris

[lechnerc77]

@aydin-ozcan - FYI: This feature will take a bit more time than expected. In the meantime we changed the timeout for environment instances and services instances from 10 to 60 minutes. The change is available in the new release 0.3.0-beta1 (https://registry.terraform.io/providers/SAP/btp/0.3.0-beta1).

[aydin-ozcan]

Thank you @lechnerc77 , this will be suffice for the moment to continue working with the provider .

[lechnerc77]

Remark for development: currently data sources and resources might reuse the same internal data structure. This needs to be refactored as timeouts are only needed in resources.

[lechnerc77]

Breaking the customizing down to the two main resources that potentially cause issues:

Resource	CREATE	UPDATE	DELETE
resource_subaccount_environment_instance	✅	✅	✅
resource_subaccount_service_instance	✅	✅	✅

[lechnerc77]

Rebased branch https://github.com/SAP/terraform-provider-btp/tree/feat-configurable-timeouts and added types for data sources of entitlement and service instance without timeout in schema