Skip to content

Commit

Permalink
fix: reprioritized FIXME comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lechnerc77 committed Jul 12, 2023
1 parent c719f8b commit 19416f4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion internal/btpcli/facade_accounts_subscription.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func (f *accountsSubscriptionFacade) getCommand() string {
}

func (f *accountsSubscriptionFacade) List(ctx context.Context, subaccountId string) ([]saas_manager_service.EntitledApplicationsResponseObject, CommandResponse, error) {
type wrapper struct { // FIXME should be in types package
type wrapper struct { // TODO should be in types package
Applications []saas_manager_service.EntitledApplicationsResponseObject `json:"applications"`
}

Expand Down
2 changes: 1 addition & 1 deletion internal/btpcli/types/xsuaa_authz/model_user_reference.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type UserReference struct {
FamilyName string `json:"familyName,omitempty"`
Origin string `json:"origin,omitempty"`

// FIXME additional fields not mentioned in the swagger file
// TODO additional fields not mentioned in the swagger file
Verified bool `json:"verified,omitempty"`
LegacyVerificationBehavior bool `json:"legacyVerificationBehavior,omitempty"`
PasswordChangeRequired bool `json:"passwordChangeRequired,omitempty"`
Expand Down
2 changes: 1 addition & 1 deletion internal/tfutils/tfutils.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func ToBTPCLIParamsMap(a any) (map[string]string, error) {
}

value = field.Elem().Interface().(string)
case "map[string][]string": // FIXME would be nice to have `enodethisasjson` tag, instead of an explicit typemapping
case "map[string][]string": // TODO would be nice to have `enodethisasjson` tag, instead of an explicit typemapping

if field.IsNil() {
continue
Expand Down

0 comments on commit 19416f4

Please sign in to comment.