fix imagePullPolicy parameter in pipelinerun (#351)

* fix imagePullPolicy parameter in pipelinerun

changelog.yaml

@@ -51,6 +51,13 @@
 - version: NEXT
   date: TBD
   changes:
+    - type: bug
+      impact: minor
+      title: Fix not working imagePullPolicy parameter in backend-api
+      description: |-
+        Before the parameter `imagePullPolicy` in the PipelineRun was not handled correctly.
+        This is fixed with this change.
+      pullRequestNumber: 351
 
     - type: internal
       impact: patch

charts/steward/templates/clustertask-jenkinsfile-runner.yaml

@@ -82,9 +82,7 @@ spec:
   steps:
   - name: jenkinsfile-runner
     image: $(params.JFR_IMAGE)
-    {{/*  Currently broken, see https://github.com/tektoncd/pipeline/issues/3423 */}}
-    {{/*  imagePullPolicy: $(params.JFR_IMAGE_PULL_POLICY) */}}
-    imagePullPolicy: IfNotPresent
+    imagePullPolicy: $(params.JFR_IMAGE_PULL_POLICY)
     # Workaround for Tekton being affected by registry rate limiting.
     # Specifying the command here prevents Tekton from downloading the image
     # manifest from the registry to obtain the entrypoint command from there.

docs/backend-api/README.md

@@ -194,7 +194,7 @@ A simple PipelineRun resource example can be found in [docs/examples/pipelinerun
 | `spec.profiles.network` | (string, optional) The name of the network profile to be used for the pipeline run.<br/><br/>Network profiles currently define the network policy for the pipeline run sandbox. In the future this might be extended to other network-related settings.<br/><br/>Network profiles are configured for each Steward installation individually. Ask the Steward administrator for possible values. For vanilla Steward installations there's one network profile called `default`.<br/><br/>If not set or empty, a default network profile will be used. |
 | `spec.jenkinsfileRunner` | (object, optional) Configuration of the Jenkinsfile Runner container (see below). |
 | `spec.jenkinsfileRunner.image` | (string, optional) The Jenkinsfile Runner container image to be used for this pipeline run. If not specified, a default image configured for the Steward installation will be used.<br/><br/>Example: `my-org/my-jenkinsfile-runner:latest` |
-| `spec.jenkinsfileRunner.imagePullPolicy` | (string, optional) The image pull policy for `spec.jenkinsfileRunner.image`. It applies only if `spec.jenkinsfileRunner.image` is set, i.e. it does _not_ overwrite the image pull policy of the _default_ Jenkinsfile Runner image. Defaults to 'IfNotPresent'.<br/><br/>**Currently broken, `IfNotPresent` is used in any case. See [tektoncd/pipeline #3423](https://github.com/tektoncd/pipeline/issues/3423)** |
+| `spec.jenkinsfileRunner.imagePullPolicy` | (string, optional) The image pull policy for `spec.jenkinsfileRunner.image`. It applies only if `spec.jenkinsfileRunner.image` is set, i.e. it does _not_ overwrite the image pull policy of the _default_ Jenkinsfile Runner image. Defaults to 'IfNotPresent'. |
 | `spec.runDetails` | (object,optional) Properties of the Jenkins build object. |
 | `spec.runDetails.jobName` | (string,optional) The name of the job this pipeline run belongs to. It is used as the name of the Jenkins job and therefore must be a valid Jenkins job name. If null or empty, `job` will be used. |
 | `spec.runDetails.sequenceNumber` | (string,optional) The sequence number of the pipeline run, which translates into the build number of the Jenkins job.  If null or empty, `1` is used. |