[CLOUDCIFEAT1-130] Avoid non atomic updates (#248)

Up to now each and every change was "commited" directly. Now we apply several changes to the memory representation of a pipeline run and "commit" these changes together. With that there is no (short) period of time where the pipeline run is inconsistent.

There are also a lot of other changes more the less related (e.g. affecting error handling)

Co-authored-by: Matthias Rinck <[email protected]>

changelog.yaml

@@ -51,12 +51,29 @@
 - version: NEXT
   date: TBD
   changes:
+
+     - type: bug
+       impact: minor
+       title: Avoid non atomic status updates
+       description: |-
+         Without this change the state might be upated e.g. to a final state
+         without setting a corresponding result. The result is provided a short period
+         of time later with an other update. In the meantime we have an invalid state.
+         With this change we apply both changes to the memory representation of a
+         pipeline run and send the update only once. With this approach there is no
+         short period of time with an invalid state
+       warning: |-
+         needs to be validated carefully since this is a bigger refactoring
+       pullRequestNumber: 248
+       jiraIssueNumber: CLOUDCIFEAT1-130
+
      - type: bug
        impact: patch
        title: Fix deletion bug #241
        description: |-
          When a pipeline run was deleted the state and the result were not updated in some edge cases. This is fixed now.
        pullRequestNumber: 250
+
 - version: "0.12.1"
   date: 2021-07-28
   changes:

charts/steward/Chart.yaml

@@ -5,8 +5,8 @@ type: application
 
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
-version: 0.12.2-dev
+version: 0.13.0-dev
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application.
-appVersion: 0.12.2-dev
+appVersion: 0.13.0-dev

pkg/apis/steward/v1alpha1/constants.go

@@ -78,6 +78,10 @@ const (
 	// faces an intermittent error during running phase.
 	EventReasonRunningFailed = "RunningFailed"
 
+	// EventReasonCleaningFailed is the reason for a event occuring when the run controller
+	// faces an intermittent error during cleanup phase.
+	EventReasonCleaningFailed = "CleaningFailed"
+
 	// EventReasonLoadPipelineRunsConfigFailed is the reason for an event occuring when the
 	// loading of the pipeline runs configuration fails.
 	EventReasonLoadPipelineRunsConfigFailed = "LoadPipelineRunsConfigFailed"