fix: notification added to announce when item is successfully removed from cart#21184
Merged
npapp-dev002 merged 48 commits intodevelopfrom Apr 1, 2026
Merged
fix: notification added to announce when item is successfully removed from cart#21184npapp-dev002 merged 48 commits intodevelopfrom
npapp-dev002 merged 48 commits intodevelopfrom
Conversation
…obal message service
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
fix/CXSPA-12118
|
| Run status |
|
| Run duration | 04m 37s |
| Commit |
|
| Committer | Norbert Papp |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
101
|
| View all changes introduced in this branch ↗︎ | |
Contributor
Merge Checks Failed |
Zeyber
requested changes
Mar 2, 2026
|
|
||
| @Input() promotionLocation: PromotionLocation = PromotionLocation.ActiveCart; | ||
|
|
||
| protected globalMessageService = inject(GlobalMessageService); |
Contributor
There was a problem hiding this comment.
We should inject this as an optional service. So that the call in remove item can also be optional (ie. this.globalMessageService?.add(.... This is because we are introducing the global message service as a new service that might not necessarily be injected already. This is how we can handle the breaking change.
Contributor
E2E Tests Failed ❌Commit: 2563e255a23121c8908270bfdc78986a59a2827c |
Contributor
Merge Checks Failed |
Zeyber
requested changes
Mar 25, 2026
| .remove(payload.userId, payload.cartId, payload.entryNumber) | ||
| .pipe( | ||
| map(() => { | ||
| this.globalMessageService.add( |
Contributor
There was a problem hiding this comment.
This method is better. Just remember to inject the service optionally otherwise the method could fail since this is a breaking change.
Contributor
Merge Checks Failed |
Zeyber
requested changes
Mar 31, 2026
| <span>{{ assistiveMsg | cxTranslate }}</span> | ||
| <div class="cx-visually-hidden" aria-live="assertive" aria-atomic="true"> | ||
| <span | ||
| *ngFor="let assistiveMsg of messages[messageType.MSG_TYPE_ASSISTIVE]" |
Contributor
There was a problem hiding this comment.
Is there any reason *ngFor has moved from the div to the span tag?
Contributor
Author
There was a problem hiding this comment.
Nope. Thanks for noticing. 👍
Contributor
Merge Checks Failed |
Contributor
Merge Checks Failed |
Zeyber
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
QA steps: